From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH RESEND] media: adv7511-v4l2: use constants for BT.2020 colorimetry
Date: Thu, 17 Apr 2025 09:03:26 +0100 [thread overview]
Message-ID: <174487700624.494853.2007394433912766175@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20250417-adv7511-ec-const-v1-1-74301e17646e@oss.qualcomm.com>
Quoting Dmitry Baryshkov (2025-04-16 23:46:01)
> Replace numeric values with constants from hdmi.h.
>
[x] adv7511-v4l2.c includes hdmi.h
[x] hdmi.h defines the same values (through an enum)
Checks out for me.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/media/i2c/adv7511-v4l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c
> index f95a99d85360aa782279a127eee37132f9ad08fb..853c7806de928da2129f603e7cb673440a1fcfac 100644
> --- a/drivers/media/i2c/adv7511-v4l2.c
> +++ b/drivers/media/i2c/adv7511-v4l2.c
> @@ -1370,9 +1370,9 @@ static int adv7511_set_fmt(struct v4l2_subdev *sd,
> case V4L2_COLORSPACE_BT2020:
> c = HDMI_COLORIMETRY_EXTENDED;
> if (y && format->format.ycbcr_enc == V4L2_YCBCR_ENC_BT2020_CONST_LUM)
> - ec = 5; /* Not yet available in hdmi.h */
> + ec = HDMI_EXTENDED_COLORIMETRY_BT2020_CONST_LUM;
> else
> - ec = 6; /* Not yet available in hdmi.h */
> + ec = HDMI_EXTENDED_COLORIMETRY_BT2020;
> break;
> default:
> break;
>
> ---
> base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
> change-id: 20250408-adv7511-ec-const-b46796340439
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
next prev parent reply other threads:[~2025-04-17 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 22:46 Dmitry Baryshkov
2025-04-17 8:03 ` Kieran Bingham [this message]
2025-04-25 9:00 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174487700624.494853.2007394433912766175@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®