From: Vinod Koul <vkoul@kernel.org>
To: vinicius.gomes@intel.com, dave.jiang@intel.com,
Purva Yeshi <purvayeshi550@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: idxd: cdev: Fix uninitialized use of sva in idxd_cdev_open
Date: Thu, 17 Apr 2025 20:48:27 +0530 [thread overview]
Message-ID: <174490310744.238609.16595322952378683226.b4-ty@kernel.org> (raw)
In-Reply-To: <20250410110216.21592-1-purvayeshi550@gmail.com>
On Thu, 10 Apr 2025 16:32:16 +0530, Purva Yeshi wrote:
> Fix Smatch-detected issue:
> drivers/dma/idxd/cdev.c:321 idxd_cdev_open() error:
> uninitialized symbol 'sva'.
>
> 'sva' pointer may be used uninitialized in error handling paths.
> Specifically, if PASID support is enabled and iommu_sva_bind_device()
> returns an error, the code jumps to the cleanup label and attempts to
> call iommu_sva_unbind_device(sva) without ensuring that sva was
> successfully assigned. This triggers a Smatch warning about an
> uninitialized symbol.
>
> [...]
Applied, thanks!
[1/1] dma: idxd: cdev: Fix uninitialized use of sva in idxd_cdev_open
commit: 97994333de2b8062d2df4e6ce0dc65c2dc0f40dc
Best regards,
--
~Vinod
next prev parent reply other threads:[~2025-04-17 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 11:02 Purva Yeshi
2025-04-10 19:40 ` Vinicius Costa Gomes
2025-04-10 19:56 ` Purva Yeshi
2025-04-10 21:00 ` Dave Jiang
2025-04-17 5:39 ` Purva Yeshi
2025-04-17 15:18 ` Vinod Koul [this message]
2025-04-18 8:33 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174490310744.238609.16595322952378683226.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=purvayeshi550@gmail.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®