From: Vinod Koul <vkoul@kernel.org>
To: nathan.lynch@amd.com, Basavaraj.Natikar@amd.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Eder Zulian <ezulian@redhat.com>
Subject: Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache
Date: Thu, 17 Apr 2025 20:48:48 +0530 [thread overview]
Message-ID: <174490312803.238725.14116695966907460215.b4-ty@kernel.org> (raw)
In-Reply-To: <20250415121312.870124-1-ezulian@redhat.com>
On Tue, 15 Apr 2025 14:13:12 +0200, Eder Zulian wrote:
> The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> resource")' but it was never used.
>
> Changes since v1:
> - Remove the 'err_cache' label and return -ENOMEM directly instead of
> assigning -ENOMEM to 'ret' and jumping to the label, since there
> are no unmanaged allocations to unwind. Based on suggestion from
> Nathan Lynch.
> - Fix checkpatch.pl error: ERROR: Please use git commit description style
> 'commit <12+ chars of sha1> ("<title line>")'
>
> [...]
Applied, thanks!
[1/1] dmaengine: ptdma: Remove unused pointer dma_cmd_cache
commit: f087965ab4aaca653d19ea3909b42e7ef2b64ba0
Best regards,
--
~Vinod
prev parent reply other threads:[~2025-04-17 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 12:13 Eder Zulian
2025-04-16 14:56 ` Nathan Lynch
2025-04-17 7:35 ` Basavaraj Natikar
2025-04-17 15:18 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174490312803.238725.14116695966907460215.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=ezulian@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.lynch@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®