From: Mark Brown <broonie@kernel.org>
To: David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Nathan Chancellor <nathan@kernel.org>
Cc: Stuart Henderson <stuarth@opensource.cirrus.com>,
Qi Zhou <qi.zhou@cirrus.com>,
Piotr Stankiewicz <piotrs@opensource.cirrus.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs48l32: Use modern PM_OPS
Date: Tue, 22 Apr 2025 14:12:54 +0100 [thread overview]
Message-ID: <174532757424.44137.16474989394967675567.b4-ty@kernel.org> (raw)
In-Reply-To: <20250418-cs48l32-modern-pm_ops-v1-1-640559407619@kernel.org>
On Fri, 18 Apr 2025 16:36:01 -0400, Nathan Chancellor wrote:
> When building for a platform that does not support CONFIG_PM, such as
> s390, cs48l32_runtime_{suspend,resume}() are unused because
> SET_RUNTIME_PM_OPS does not reference its argument when CONFIG_PM is not
> set:
>
> sound/soc/codecs/cs48l32.c:3822:12: error: 'cs48l32_runtime_suspend' defined but not used [-Werror=unused-function]
> 3822 | static int cs48l32_runtime_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/codecs/cs48l32.c:3779:12: error: 'cs48l32_runtime_resume' defined but not used [-Werror=unused-function]
> 3779 | static int cs48l32_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: cs48l32: Use modern PM_OPS
commit: 6070ef6e4202dae61027c146d797319b9e5c07b3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2025-04-22 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 20:36 Nathan Chancellor
2025-04-19 9:58 ` Richard Fitzgerald
2025-04-22 13:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174532757424.44137.16474989394967675567.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=piotrs@opensource.cirrus.com \
--cc=qi.zhou@cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=stuarth@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®