mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: virtualization@lists.linux.dev, mst@redhat.com,
	jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
	hawk@kernel.org, john.fastabend@gmail.com, eperezma@redhat.com,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v4 0/4] virtio-net: disable delayed refill when pausing rx
Date: Wed, 23 Apr 2025 01:50:28 +0000	[thread overview]
Message-ID: <174537302875.2111809.8543884098526067319.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250417072806.18660-1-minhquangbui99@gmail.com>

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 17 Apr 2025 14:28:02 +0700 you wrote:
> Hi everyone,
> 
> This series tries to fix a deadlock in virtio-net when binding/unbinding
> XDP program, XDP socket or resizing the rx queue.
> 
> When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call
> napi_disable() on the receive queue's napi. In delayed refill_work, it
> also calls napi_disable() on the receive queue's napi. When
> napi_disable() is called on an already disabled napi, it will sleep in
> napi_disable_locked while still holding the netdev_lock. As a result,
> later napi_enable gets stuck too as it cannot acquire the netdev_lock.
> This leads to refill_work and the pause-then-resume tx are stuck
> altogether.
> 
> [...]

Here is the summary with links:
  - [v4,1/4] virtio-net: disable delayed refill when pausing rx
    https://git.kernel.org/netdev/net/c/4bc12818b363
  - [v4,2/4] selftests: net: move xdp_helper to net/lib
    (no matching commit)
  - [v4,3/4] selftests: net: add flag to force zerocopy mode in xdp_helper
    (no matching commit)
  - [v4,4/4] selftests: net: add a virtio_net deadlock selftest
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-04-23  1:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17  7:28 Bui Quang Minh
2025-04-17  7:28 ` [PATCH v4 1/4] " Bui Quang Minh
2025-04-21  3:03   ` Jason Wang
2025-04-17  7:28 ` [PATCH v4 2/4] selftests: net: move xdp_helper to net/lib Bui Quang Minh
2025-04-17  7:28 ` [PATCH v4 3/4] selftests: net: add flag to force zerocopy mode in xdp_helper Bui Quang Minh
2025-04-23  1:34   ` Jakub Kicinski
2025-04-17  7:28 ` [PATCH v4 4/4] selftests: net: add a virtio_net deadlock selftest Bui Quang Minh
2025-04-23  1:41   ` Jakub Kicinski
2025-04-23 15:20     ` Bui Quang Minh
2025-04-23 22:23       ` Jakub Kicinski
2025-04-24 10:33         ` Bui Quang Minh
2025-04-24 22:07           ` Jakub Kicinski
2025-04-23  1:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174537302875.2111809.8543884098526067319.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=hawk@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minhquangbui99@gmail.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®