From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02D61263F4E for ; Wed, 23 Apr 2025 02:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745374173; cv=none; b=hkWEIs+LWDk4MVcqgnC7MSRVXn7Wv+2ENXjv/sHyW5pRB6NEGwn946qY+sS5HaWkva+HSwLyOnAvWxDl2D5zHkQT74ApWY+359CJiXZdHL6mkqSKqK31S+JeOZ2sKoMvIZhcm+GsTYeFvoiSEWTDEd2cXcslInNcdL9Nmb9KuHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745374173; c=relaxed/simple; bh=/NMem5ifgNES89PzacLrSaCky+MNKn14k07t4KV28GM=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=JqPsWzZKUMdOq/jRBOmOI7pGKlkRUswT+2kFeOUtNqxu8cGPeyVIdpG7PG7nUtx7B647LkrGrCdFc0lpyxEgiFmYvVlluEFQXRQzuT/MyeOuKR0ZXtDDLL4urRmLSnwKjMqaAAkFgx5ZXejQTfm2nJ/ssxzC2QiSbs42l6z7WjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=HmpxRr9X; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="HmpxRr9X" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-85e46f5c50fso154017739f.3 for ; Tue, 22 Apr 2025 19:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1745374168; x=1745978968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bDncI1nPVws6EBYZHfi3/MSZu0PJAZs4upykCL1QGVY=; b=HmpxRr9XLvbg9aiOvT5GTRaVODwGD7ofjXEmI0NwV4mXDTX9c9xT18WKlMiNLLzLhe xrij/9gDLXH5y3jEZZp+vLbhb7n/F0CC3QeLEGCnDMKzNWQ8L1y1AQNZ+Ta1qm18l9z2 wE07bVYvVwuek2g3oLKugarlNElfoB5gQ4Xzw0hSGK1A4m/IaRqmWM3Teb8fwU2h4sTi jiH3ukql4dSeqmrFEPft6vrv+cUKY4DfHEHGXF/NK6ux0GkmlmQ65lUI3TcDy6izoMQU X71XS1GRKJj2c/L/7J8meH0hOz9bXh5EEtQ8+TNpVIYwcpvc6MuAwuz4P9jow5t4l00t suiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745374168; x=1745978968; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDncI1nPVws6EBYZHfi3/MSZu0PJAZs4upykCL1QGVY=; b=Tw5q0ujisLelshC2jRnI24k/EZIEDz/elLEUh67M5x5CyDAegBW1vJrwRZx4qu/IXT nbSLij1QP2iWIScyKpcDtpW9AgRt5w5HCKnJV1JT4ySIBJ0OX+BIY/a6YOe6PX2MfDAv hnRGx76WJdoaMMzpUQ+ny79rKlTM95EQ6sIGjRhJSCMnzsNmzRfK/gmfS6ib7aKFH7IM HFmOFQoR1HwVQ/t6MXqYR2UVaT1sf3DNLqznHJvPu1oqEq1O2Qivr9Z2axnhO89sdsJK 6PWR43uKYQMrg2j3VGK1ujjKKHNdJBgUPq+HHjPArDIAe8uZTObRxi+tyVrSggl6MH73 A3hQ== X-Forwarded-Encrypted: i=1; AJvYcCUhDrzrk6pkpM5sbNpTluPy7aYOCBN5wAsNHYouwD+VpsVtXjJA2wAx+jsZ14rOLmfhNMuzq8mEzfAsr7U=@vger.kernel.org X-Gm-Message-State: AOJu0YxndctvlETShZfoVY6OpgaUSXaRucxldrQzdoIZ5lg9R34805hM drB3JikOHi7XE0LLRcsPw8F8NQIzyTlK1Mg4xKTM1ZN+gAboksJzc6Jkx2Hg7rk5qqB53f/AvgD 2 X-Gm-Gg: ASbGncs6ymbJMRqXYUaGHoZM6Lel0kIdcjHuiawhTMJbT2Cr4nybMsXe0TQYATb8PPT JCkdS7EWSjmkvn5p/U4x8F9fQtkB2ggiTqjt1g1U4p7NJF2SYjS/xRdiiXpHoDzq72Uvimyg5v7 8KWiOwuCqIiJ2WQApKLTOAs5f5osIlXV49OcmiTWIoN0FmW5HN/A1nDQIGvD33k4uwuwEqdwvyx GbjtLrA6NLw5ui2CJ2YBktJxxvCXfJmSin0heg5GlLq8EycFIk6n3S2lCthzyrb4/VuBz8og5lc L1pGYn3JEJ/c8CbUciRZuK8w0p731zek X-Google-Smtp-Source: AGHT+IEgm4a1sBAZfV84Lo+Jj62woBUyaarGSN3fVcO/fQpfQe7SP2Yo0ZBKUHqWAvQ1YYJuA9QRsQ== X-Received: by 2002:a05:6602:7506:b0:861:722e:2cbc with SMTP id ca18e2360f4ac-861dbedeb19mr2091941839f.12.1745374168145; Tue, 22 Apr 2025 19:09:28 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f6a3933d27sm2593769173.90.2025.04.22.19.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 19:09:27 -0700 (PDT) From: Jens Axboe To: Ming Lei , Caleb Sander Mateos Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20250416170154.3621609-1-csander@purestorage.com> References: <20250416170154.3621609-1-csander@purestorage.com> Subject: Re: [PATCH] ublk: remove unnecessary ubq checks Message-Id: <174537416718.373753.18092056116763739728.b4-ty@kernel.dk> Date: Tue, 22 Apr 2025 20:09:27 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-7b9b9 On Wed, 16 Apr 2025 11:01:53 -0600, Caleb Sander Mateos wrote: > ublk_init_queues() ensures that all nr_hw_queues queues are initialized, > with each ublk_queue's q_id set to its index. And ublk_init_queues() is > called before ublk_add_chdev(), which creates the cdev. Is is therefore > impossible for the !ubq || ub_cmd->q_id != ubq->q_id condition to hit in > __ublk_ch_uring_cmd(). Remove it to avoids some branches in the I/O path. > > > [...] Applied, thanks! [1/1] ublk: remove unnecessary ubq checks commit: 4c7d3c88c77bf227c12ef13e8461a0c940f775e8 Best regards, -- Jens Axboe