From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15986258CEA for ; Fri, 2 May 2025 15:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746199534; cv=none; b=Umm3P9r8+IHHenM089MvyI62eJjz2hlMvOCCejqM2TAs7kshOuoh8vQFOWkEt+6LtN1HcCBMmknV9NTRZSKCSZaOKX3wuY9c76KoV9UmdquQyHvht2zasryAy9VbKlwwEarIA8Z73f1R0f9ePaicdccf3Vd0Qk7gL3lwyEHgQCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746199534; c=relaxed/simple; bh=pqY0MN29Mdh1goI8G84Wi6zCZ/NZpChHhO6QOqDWs7c=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=TRe5wZX9R/U13iDyrvaXuEYZ2cjbnooMSwMxX1gXt2Xjn0WwJxogdJ/KoYC3sKSuJGuU9oDF5EmkF8TaU+VpXCV+AQ16JzCqN3eB0D97MjgguWsx5sxROpjceWkhA2/T/ARx/ghSOwHbJqa+oNChYMHawsAJmrb9BguFBP8B8lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=oddsGi/u; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="oddsGi/u" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-85e15dc801aso203553439f.2 for ; Fri, 02 May 2025 08:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1746199531; x=1746804331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ktvJ6GL2VHKlqfUp9zp0jfzB7CN4Pf2PARMJI+Ww564=; b=oddsGi/uNRivO80i3cDIxO/I/o4XDo0g8EWMFsGyEFTtxodwu+EsqUQzdXxpbRkyhw TafLoqrpjl+rpQ7wBCqao1kom5HKBNBb+eDxYyNChVjdHzNB5TYnVRmyRiuNnIelOD/T Oid0lWIMWePQkVWLxemuweLqOSrTiURRq4j/ea0Gko/NSQddPjKwHArX/hLeUSMMP8sj T5+1yQRHi2rIu2XfqzDcHOeqGdGLwtNjN3kWCx7mkYNPOIGSPyX5nIoP4vjMrPorzvIQ Y0s+Wbc2ZBNwCzuEavsE0yo19a58KByFHGmAL5+1bZ8YGC1ukmRys0rcs47B0hQJDwiJ AMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746199531; x=1746804331; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ktvJ6GL2VHKlqfUp9zp0jfzB7CN4Pf2PARMJI+Ww564=; b=Oxa9tGwV2Fbo1x+NGOPVluSX6vYRqUqjdINIkrmWdTlJIfFGi2HnrBHP8DH2fg9wYu aehxqCa3cSx4let3IAKf3ssHIxeGBHMtbxsgssA16c0OzGhcXuwyReE6iRASq/0Atg2e HlL97wL3TQyW5e5+2yyAJm098qpE1dmIBLEjuTelPe989rL8YN6Bl6ijiXsjEpGzHgdm QHiOLL8/k9sNYuojOEF5zQ+T2zGIGM1mQhOZ6nv9gticPgLhShB2Lue77uOO8b2TKMfg HBKW5wQcAs2i3EBLaEyc8PBwu3l7eIlWCPkEPOEdh5XXOta14KtKxFmTqfOFqe6zYeNH puNg== X-Forwarded-Encrypted: i=1; AJvYcCV9CkqH0KEfMujSxQLBSAmLY4/FNb3g64XI0NErSR/4ynQDteCCnD+kH76o6jUf3dkNC22jI5TbWGEYKpw=@vger.kernel.org X-Gm-Message-State: AOJu0YwYAgEwAEV6a0hpNHDKRuux14+Mko4Y5ZeLRbs/TFIucw4hycbS 7/r+zUBH4HExdBBLdw6ZgsxSOs4H7LnqLQvjaL74nAgyljx5l4XCO+Yo+lRHHexoQY0Go7NbOil b X-Gm-Gg: ASbGncuWK63ONUG9HkMJ+NEjRFvJqU1vLuW6Nhs0cJkT29QCTPM6I0dnYN0j9i7C8QM v50aFGaLHt/NyWLthYLpEzEXMcZrtWI05UQvEAV+zZ6zCtmQ1maS9eWQWW5ZEyhrvRpNluV0BoR MfzYKgA1RIRc9TyD2N8ZyXoWsj+qcYTHXtDiuzTx3qsfTX0tc9utJKTM/nLRs9mTQ3KskUVnC3B ihoydnfj9gpGrfAWxT6s70A0yHwdpTjIQA/4HF4XeXVajtAS1eO2wpyMW3J2gHmHmdqVtlMX+SZ FlL5E4W8B+7flk8PWnMUPlVX7a0yW3qFKf0nCHX6Fw== X-Google-Smtp-Source: AGHT+IEl5txDpAkr/IpzX570Ho9QLPBFGnfb5pOFaOhpmsfAkNtNXEi7SaGfECANczel4I1mfYIn/g== X-Received: by 2002:a05:6e02:1fcb:b0:3d4:70ab:f96f with SMTP id e9e14a558f8ab-3d97c199938mr40956615ab.8.1746199531061; Fri, 02 May 2025 08:25:31 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f88aa8e1f7sm429300173.121.2025.05.02.08.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 08:25:30 -0700 (PDT) From: Jens Axboe To: Ming Lei , Caleb Sander Mateos Cc: Uday Shankar , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20250430225234.2676781-1-csander@purestorage.com> References: <20250430225234.2676781-1-csander@purestorage.com> Subject: Re: [PATCH v2 0/9] ublk: simplify NEED_GET_DATA handling and request lookup Message-Id: <174619953036.748556.5897249938124902151.b4-ty@kernel.dk> Date: Fri, 02 May 2025 09:25:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-7b9b9 On Wed, 30 Apr 2025 16:52:25 -0600, Caleb Sander Mateos wrote: > Remove accesses to ublk_io's cmd field after the I/O request is posted to the > ublk server. This allows the cmd field to be overlapped with a pointer to the > struct request, avoiding several blk_mq_tag_to_rq() lookups. > > Fix a couple of typos noticed along the way. > > Caleb Sander Mateos (8): > ublk: fix "immepdately" typo in comment > ublk: remove misleading "ubq" in "ubq_complete_io_cmd()" > ublk: take const ubq pointer in ublk_get_iod() > ublk: don't log uring_cmd cmd_op in ublk_dispatch_req() > ublk: factor out ublk_start_io() helper > ublk: don't call ublk_dispatch_req() for NEED_GET_DATA > ublk: check UBLK_IO_FLAG_OWNED_BY_SRV in ublk_abort_queue() > ublk: store request pointer in ublk_io > > [...] Applied, thanks! [1/9] ublk: factor out ublk_commit_and_fetch commit: 0cb39afd2a4d438b16d743952eb68c683c663a1e [2/9] ublk: fix "immepdately" typo in comment commit: 80c0789a7ddc89adb726e407ca22d9689608b710 [3/9] ublk: remove misleading "ubq" in "ubq_complete_io_cmd()" commit: 5a43d93588dca88af0333ce18dedcfb0276ec4fe [4/9] ublk: take const ubq pointer in ublk_get_iod() commit: 2a86eec6396ff6d40e46d5cc11f99f1e7bbec78e [5/9] ublk: don't log uring_cmd cmd_op in ublk_dispatch_req() commit: 551270690dd6c751a6d62f272cf068bfef9a1729 [6/9] ublk: factor out ublk_start_io() helper commit: 2fcb88bdf2e62a6aae211c8603341fd2e7b16a69 [7/9] ublk: don't call ublk_dispatch_req() for NEED_GET_DATA commit: 9810362a57cb633d808cdfd51e8cae21243f0660 [8/9] ublk: check UBLK_IO_FLAG_OWNED_BY_SRV in ublk_abort_queue() commit: 8ed95b54701a8e946b86ffdeeac8603316e0a59d [9/9] ublk: store request pointer in ublk_io commit: 64d1dc522b349a257256f636feb335441cca2571 Best regards, -- Jens Axboe