From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753551AbdHUOSF (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Aug 2017 10:18:05 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:21609 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753264AbdHUOSD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Aug 2017 10:18:03 -0400
X-AuditID: b6c32a46-f790d6d000003bf5-25-599aeb99d838
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: pxa3xx_gcu: fix error return code in
 pxa3xx_gcu_probe()
Date: Mon, 21 Aug 2017 16:17:58 +0200
Message-id: <1746251.LKqyi5Vgub@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20170808221729.GA2208@embeddedgus>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7bCmhe7M17MiDZbPFbPYukfV4kTfB1aL
        y7vmsDkwe6w7qOrxeZNcAFMUl01Kak5mWWqRvl0CV8bpLf+YCuaxVez59J61gXE2axcjJ4eE
        gInE4uftzBC2mMSFe+vZuhi5OIQEdjBKrDywC8r5zijx78xcFpiOkyv+gXULCWxglLi8pxii
        6CujxMmrjYwgCTYBK4mJ7avAbBEBI4nZM7rBGpgFbCVenz4DFhcWiJF4cv8+O4jNIqAqMWXl
        f7A4r4CmxKFt78GWiQp4SWzZ184EYnMKGEicu9cLVSMo8WPyPRaImfIS+/ZPhZqvI3H22DpG
        kIMkBBrZJCZ9bGWEuNpF4uO8g1C2sMSr41vYIWxpiWerNkLFpzNKbP8tAdG8mVFi1e4JUEXW
        EoePX4TawCfRcfgvUJwDKM4r0dEmBFHiIXF//1pomDpK7Ph5kR0SKs2MEkuWPGGbwCg3C8nh
        s5AcPgvJ4QsYmVcxiqUWFOempxYbFRjpFSfmFpfmpesl5+duYgRHvZbbDsYl53wOMQpwMCrx
        8N7InxUpxJpYVlyZe4hRgoNZSYT34B6gEG9KYmVValF+fFFpTmrxIUZpDhYlcd66bdcihATS
        E0tSs1NTC1KLYLJMHJxSDYzXUp9J7Gw82MwU6JkXNr8utt9l/ly93ct+GxsYGCbWmd/Ypxh2
        7Z1Jhc3TOj7bFXZprmvWVmtoTb92gf8bQ/7nCxzHfjCZNZw+EbTK6u1vPv6DFxa+MElwfak3
        Zc+xe0um3nKZ3VjvfvN/+N4XJoICS10Uflk8eH8zwCDKwpGFKyTpz6rgNHUlluKMREMt5qLi
        RACaQEqr9gIAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsVy+t9jQd2Zr2dFGjw8w2yxdY+qxYm+D6wW
        l3fNYXNg9lh3UNXj8ya5AKYoLpuU1JzMstQifbsErozTW/4xFcxjq9jz6T1rA+Ns1i5GTg4J
        AROJkyv+AdlcHEIC6xgltvdPhHK+MkocOHwYrIpNwEpiYvsqRhBbRMBIYvaMbrA4s4CtxOvT
        Z8DiwgIxEk/u32cHsVkEVCWmrPwPFucV0JQ4tO09C4gtKuAlsWVfOxOIzSlgIHHuXi8jxLJW
        Ron+Aw/YIRoEJX5MvscCsUBeYt/+qVDLtCTW7zzONIGRfxaSsllIymYhKVvAyLyKUTK1oDg3
        PbfYqMAoL7Vcrzgxt7g0L10vOT93EyMwHLcd1urfwfh4SfwhRgEORiUeXoOiWZFCrIllxZW5
        hxglOJiVRHgP7gEK8aYkVlalFuXHF5XmpBYfYpTmYFES583smxEpJJCeWJKanZpakFoEk2Xi
        4JRqYMwXkgh6ZVujrPD6/tG9GecvTP78J8Biu1xz1uMg0Wv8PjkPhOp8znjP4/3c66m1+h7f
        xJZfDfyTLOJehSkuc9s5S+uDTf7W/Lq9bhnZljtqgs8sP94w6wjD+TdMBudXROyquZO7JG3H
        77MmodkiLzmS/85duZLH6sAkRk3L4/+ef2ornFEko6vEUpyRaKjFXFScCABHhi+MQwIAAA==
X-CMS-MailID: 20170821141801epcas2p1d1de2c73b2c4512371dbb0b04aaf4e11
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.143
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 102P
X-CMS-RootMailID: 20170808221735epcas1p41578ae889d438fd96e3162ef45cf701a
X-RootMTR: 20170808221735epcas1p41578ae889d438fd96e3162ef45cf701a
References: <CGME20170808221735epcas1p41578ae889d438fd96e3162ef45cf701a@epcas1p4.samsung.com>
        <20170808221729.GA2208@embeddedgus>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, August 08, 2017 05:17:30 PM Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the pxa3xx_gcu driver
> ignores it and always returns -ENODEV. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
> 
> Also, notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
> 
> Print and propagate the return value of platform_get_irq on failure.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics