From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932807AbcGETuZ (ORCPT ); Tue, 5 Jul 2016 15:50:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55276 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbcGETuX convert rfc822-to-8bit (ORCPT ); Tue, 5 Jul 2016 15:50:23 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160705.101636.1426176903162735420.davem@davemloft.net> References: <20160705.101636.1426176903162735420.davem@davemloft.net> <146772433082.21657.14046392058484946464.stgit@warthog.procyon.org.uk> <146772436726.21657.7089071379028604342.stgit@warthog.procyon.org.uk> To: David Miller Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17462.1467748220.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Tue, 05 Jul 2016 20:50:20 +0100 Message-ID: <17463.1467748220@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 05 Jul 2016 19:50:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > I don't see anything in this patch dealing with refcount helper functions. I'm amending the patch description to: rxrpc: Provide queuing helper functions Provide queueing helper functions so that the queueing of local and connection objects can be fixed later. The issue is that a ref on the object needs to be passed to the work queue, but the act of queueing the object may fail because the object is already queued. Testing the queuedness of an object before hand doesn't work because there can be a race with someone else trying to queue it. What will have to be done is to adjust the refcount depending on the result of the queue operation. Signed-off-by: David Howells but not changing the patch. David