From: "tip-bot2 for Frank Li" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Frank Li <Frank.Li@nxp.com>, Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/msi] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()
Date: Thu, 08 May 2025 17:27:12 -0000 [thread overview]
Message-ID: <174672523272.406.13475096235281643458.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250414-ep-msi-v18-1-f69b49917464@nxp.com>
The following commit has been merged into the irq/msi branch of tip:
Commit-ID: 9a958e1fd40d6fae8c66385687a00ebd9575a7d2
Gitweb: https://git.kernel.org/tip/9a958e1fd40d6fae8c66385687a00ebd9575a7d2
Author: Frank Li <Frank.Li@nxp.com>
AuthorDate: Mon, 14 Apr 2025 14:30:55 -04:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 07 May 2025 17:49:00 +02:00
platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()
platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating
the MSI domain for a platform device, and allocate a number of MSIs in that
domain.
platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI
domain alive.
Given that platform_device_msi_init_and_alloc_irqs() is the sole tool a
platform device has to allocate platform MSIs, it makes sense for
platform_device_msi_free_irqs_all() to teardown the MSI domain at the same
time as the MSIs.
This avoids warnings and unexpected behaviours when a driver repeatedly
allocates and frees MSIs.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20250414-ep-msi-v18-1-f69b49917464@nxp.com
---
drivers/base/platform-msi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index 0e60dd6..70db08f 100644
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -95,5 +95,6 @@ EXPORT_SYMBOL_GPL(platform_device_msi_init_and_alloc_irqs);
void platform_device_msi_free_irqs_all(struct device *dev)
{
msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN);
+ msi_remove_device_irq_domain(dev, MSI_DEFAULT_DOMAIN);
}
EXPORT_SYMBOL_GPL(platform_device_msi_free_irqs_all);
next prev parent reply other threads:[~2025-05-08 17:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 18:30 [PATCH v18 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li
2025-04-14 18:30 ` [PATCH v18 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all() Frank Li
2025-05-08 17:27 ` tip-bot2 for Frank Li [this message]
2025-04-14 18:30 ` [PATCH v18 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable() Frank Li
2025-05-08 17:27 ` [tip: irq/msi] " tip-bot2 for Frank Li
2025-04-14 18:30 ` [PATCH v18 03/15] irqchip/gic-v3-its: Set IRQ_DOMAIN_FLAG_MSI_IMMUTABLE for ITS Frank Li
2025-05-08 17:27 ` [tip: irq/msi] " tip-bot2 for Frank Li
2025-04-14 18:30 ` [PATCH v18 04/15] dt-bindings: PCI: pci-ep: Add support for iommu-map and msi-map Frank Li
2025-04-15 23:27 ` Rob Herring (Arm)
2025-05-08 17:27 ` [tip: irq/msi] " tip-bot2 for Frank Li
2025-04-14 18:30 ` [PATCH v18 05/15] irqchip/gic-v3-its: Add support for device tree msi-map and msi-mask Frank Li
2025-05-08 17:27 ` [tip: irq/msi] " tip-bot2 for Frank Li
2025-04-14 18:31 ` [PATCH v18 06/15] PCI: endpoint: Set ID and of_node for function driver Frank Li
2025-04-14 18:31 ` [PATCH v18 07/15] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Frank Li
2025-04-14 18:31 ` [PATCH v18 08/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check Frank Li
2025-05-07 15:03 ` Thomas Gleixner
2025-04-14 18:31 ` [PATCH v18 09/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Frank Li
2025-04-14 18:31 ` [PATCH v18 10/15] PCI: endpoint: pci-epf-test: Add doorbell test support Frank Li
2025-04-14 18:31 ` [PATCH v18 11/15] misc: pci_endpoint_test: Add doorbell test case Frank Li
2025-04-14 18:31 ` [PATCH v18 12/15] selftests: pci_endpoint: " Frank Li
2025-04-14 18:31 ` [PATCH v18 13/15] pci: imx6: Add helper function imx_pcie_add_lut_by_rid() Frank Li
2025-04-14 18:31 ` [PATCH v18 14/15] pci: imx6: Add LUT setting for MSI/IOMMU in Endpoint mode Frank Li
2025-04-14 18:31 ` [PATCH v18 15/15] arm64: dts: imx95: Add msi-map for pci-ep device Frank Li
2025-05-02 1:10 ` [PATCH v18 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li
2025-05-08 17:26 ` Thomas Gleixner
2025-05-11 8:24 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174672523272.406.13475096235281643458.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=Frank.Li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®