From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031855AbdEXUFy (ORCPT ); Wed, 24 May 2017 16:05:54 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:52704 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934566AbdEXUFu (ORCPT ); Wed, 24 May 2017 16:05:50 -0400 Date: Wed, 24 May 2017 22:05:26 +0200 (CEST) From: Stefan Wahren To: David Miller Cc: linux-serial@vger.kernel.org, jslaby@suse.com, gregkh@linuxfoundation.org, netdev@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, kubakici@wp.pl, mark.rutland@arm.com, LinoSanfilippo@gmx.de, devicetree@vger.kernel.org Message-ID: <1746915556.279475.1495656327010@email.1und1.de> In-Reply-To: <20170524.154111.404338711401048909.davem@davemloft.net> References: <1495545173-22150-1-git-send-email-stefan.wahren@i2se.com> <1495545173-22150-2-git-send-email-stefan.wahren@i2se.com> <20170524.154111.404338711401048909.davem@davemloft.net> Subject: Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev34 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:zBcj7bz0POPXsI8keOakNf0q0qId2mDHLEbmHJ0QVrqyqJECF4E bCBNMS+WRWAYAPcVlwClLTZTCP4jqiY2DYxV1QrWIl8fXUaTBpqUdfcm5Qk9fzR/OHwCWrB fQQmZSnIQUZbEkHr2aWIsx9h1Q/h15JkeyW3JFb5jJuaziIfYx2vH+Durak0OI1TQs1V2JB 5ZFl78ECea2TfOiy3XmBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Gzc4j2gyzjg=:JNpNcM+QSceBKJzli3QerZ AfeU9LPzidskN7hFj7Xi6hKf5e/wtjywh11TZkW43HXyIzH62ReuAuwXEfk8FKgaqMCNBdonQ leXwXs8vdAN4QpLq8dHOyVuj2IKgxsFd4CnWJeoxxL+JAUtMQ1TnIvlKpk9+y8oKmfbSvv403 IaE4n908e+HWzmv3STcJ6Awht8OceAOo6lR4i/7vu6FPeqlsqDOIlvHWYEUFpT7W9gsPiGdB5 t3Wj/IvQ6SU4y4qVllqcwPojjXWSsTOFXRTBlaICTOw0KoPMiz98g6GCdAmdtiOs1fZz/JXFe CJBtQq3UJYOnybHcPaI3G3Cxf2iPXp+tDFkPjZ3eacDLuGc8TTxIEqKSoEbnMWOL58s4Fhpnp 40Ws7yHWw9FKiXfp3xKmlSadpGyHtPNKB8TpWDqRXV5dIAd5rf6uTwiZaa2OaGtGEU9xyDc5i zmC9Gy5VIwO4qruNBydLC4ix7E+5U1G/4MTYJZA0S/N79hMGRFigvnzkJEheDP2AoB1e2ej6q kIuflXjoG3d1D4vM+YF8eMEtWc5Xyi7ZzrW5PlqgLW1iBM/lwh0/kD7UklL7q80oA8dXw8L9H GSf8LoIqyqgMm9+pruYM8Vrv57MzXefSmzfm69fNgqmNGIjzTDBtzrwjOFNgcfgtniR/SUZZ3 KFRKbOWEcc35T7qRj9KF0ZwHniehvMq201nS7kJPBH65FGIF3gZVcqgVU2tzX8owUf0ovCJFJ c8I0XQVp2KaV2XId Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > David Miller hat am 24. Mai 2017 um 21:41 geschrieben: > > > From: Stefan Wahren > Date: Tue, 23 May 2017 15:12:37 +0200 > > > Most of the includes in qca_7k.c are unnecessary so we better remove them. > > > > Signed-off-by: Stefan Wahren > > --- > > drivers/net/ethernet/qualcomm/qca_7k.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c > > index f0066fb..557d53c 100644 > > --- a/drivers/net/ethernet/qualcomm/qca_7k.c > > +++ b/drivers/net/ethernet/qualcomm/qca_7k.c > > @@ -23,11 +23,7 @@ > > * kernel-based SPI device. > > */ > > > > -#include > > -#include > > -#include > > #include > > -#include > > > > #include "qca_7k.h" > > > > -- > > 2.1.4 > > > > Changes like this drive me crazy. > > The only reason you can remove those headers is because you are obtaining > things indirectly via qca_7k.h > > And if that is indeed the case, you are also getting qca_spi.h which > in turn includes linux/spi/spi.h > > So you could have removed that as well. > > But seriously, it is so much harder to understand a driver and what > interfaces it needs via header files when you hide _all_ of it behind > these local private header files which just include _everything_ > and then _every_ foo.c file in your driver gets _all_ of those kernel > headers whether they need it or not. > > So if just one foo.c file needs 20 extra kernel headers than the rest > of the files in the driver, every foo.c file eats that cost of > including them. > > I really don't like when drivers move in this direction for that > reason. And at best, as described at the beginning of my response, > this change is incomplete. > The intension of this change wasn't to hide the includes into qca_7k.h AFAIK these ones above aren't necessary (no init, no kernel module, no kernel parameter, no kernel version) for this C file. So i will double check it.