From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>, Rong Zhang <i@rong.moe>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, "Brian Gerst" <brgerst@gmail.com>,
"Borislav Petkov" <bp@alien8.de>,
"Petr Tesařík" <petr@tesarici.cz>,
bugzilla-daemon@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] HID: bpf: abort dispatch if device destroyed
Date: Tue, 13 May 2025 16:01:48 +0200 [thread overview]
Message-ID: <174714490874.1690070.753423275910575017.b4-ty@kernel.org> (raw)
In-Reply-To: <20250512152420.87441-1-i@rong.moe>
On Mon, 12 May 2025 23:24:19 +0800, Rong Zhang wrote:
> The current HID bpf implementation assumes no output report/request will
> go through it after hid_bpf_destroy_device() has been called. This leads
> to a bug that unplugging certain types of HID devices causes a cleaned-
> up SRCU to be accessed. The bug was previously a hidden failure until a
> recent x86 percpu change [1] made it access not-present pages.
>
> The bug will be triggered if the conditions below are met:
>
> [...]
Applied to hid/hid.git (for-6.15/upstream-fixes), thanks!
[1/1] HID: bpf: abort dispatch if device destroyed
https://git.kernel.org/hid/hid/c/578e1b96fad7
Cheers,
--
Benjamin Tissoires <bentiss@kernel.org>
prev parent reply other threads:[~2025-05-13 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-220083-6385@https.bugzilla.kernel.org/>
2025-05-06 14:55 ` [Bug 220083] New: [REGRESSION, BISECTED] x86 ASM changes make dispatch_hid_bpf_output_report access not-present page Borislav Petkov
2025-05-06 15:35 ` Benjamin Tissoires
2025-05-07 11:03 ` Rong Zhang
2025-05-07 17:33 ` Rong Zhang
2025-05-07 22:14 ` Brian Gerst
2025-05-08 12:17 ` Rong Zhang
2025-05-12 14:43 ` Benjamin Tissoires
2025-05-12 15:24 ` [PATCH] HID: bpf: abort dispatch if device destroyed Rong Zhang
2025-05-12 19:17 ` Petr Tesařík
2025-05-13 14:01 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174714490874.1690070.753423275910575017.b4-ty@kernel.org \
--to=bentiss@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=brgerst@gmail.com \
--cc=bugzilla-daemon@kernel.org \
--cc=i@rong.moe \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@tesarici.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®