From: "Rob Herring (Arm)" <robh@kernel.org>
To: "Clément Le Goffic" <clement.legoffic@foss.st.com>
Cc: linux-arm-kernel@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/8] Introduce HDP support for STM32MP platforms
Date: Tue, 20 May 2025 16:09:20 -0500 [thread overview]
Message-ID: <174777533581.1435243.228426835513916964.robh@kernel.org> (raw)
In-Reply-To: <20250520-hdp-upstream-v2-0-53f6b8b5ffc8@foss.st.com>
On Tue, 20 May 2025 17:02:27 +0200, Clément Le Goffic wrote:
> This patch series introduces the Hardware Debug Port (HDP) support for
> STM32MP platforms.
>
> It includes the addition of device tree bindings, the HDP driver,
> and updates to the device tree files for STM32MP13, STM32MP15,
> and STM32MP25 SoCs.
> The series also updates the MAINTAINERS file to include myself as the
> maintainer for the STM32 HDP driver and adds the necessary
> pinmux configurations for HDP pins on STM32MP157C-DK2 as example.
>
> Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
> ---
> Changes in v2:
> - Remove bindings header files with function name as #define
> - Add match_data with function name for three compatible:
> "st,stm32mp131-hdp", "st,stm32mp151-hdp" and "st,stm32mp251-hdp".
> - Rework a bit the driver to use match_data.
> - Remove the use of `dev_err_probe(` in the resume ops.
> - Remove `MODULE_ALIAS(`.
> - Remove the vertical bar in bindings description paragraph.
> - Fix an error in the `pinctrl-0` parameter of the binding example, it
> was refering a node that wasn't existing.
> - Use uppercase pin names.
> - Link to v1: https://lore.kernel.org/r/20250225-hdp-upstream-v1-0-9d049c65330a@foss.st.com
>
> ---
> Clément Le Goffic (8):
> dt-bindings: pinctrl: stm32: Introduce HDP
> pinctrl: stm32: Introduce HDP driver
> MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer
> ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13
> ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15
> ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25
> ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node
> ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board
>
> .../bindings/pinctrl/st,stm32-pinctrl-hdp.yaml | 188 ++++++
> MAINTAINERS | 6 +
> arch/arm/boot/dts/st/stm32mp131.dtsi | 6 +
> arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi | 25 +
> arch/arm/boot/dts/st/stm32mp151.dtsi | 7 +
> arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 6 +
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 7 +
> drivers/pinctrl/stm32/Kconfig | 14 +
> drivers/pinctrl/stm32/Makefile | 1 +
> drivers/pinctrl/stm32/pinctrl-stm32-hdp.c | 736 +++++++++++++++++++++
> 10 files changed, 996 insertions(+)
> ---
> base-commit: 09fac5c576bbff764dddf2baca0038b359376fd8
> change-id: 20250224-hdp-upstream-622e5da14a9f
>
> Best regards,
> --
> Clément Le Goffic <clement.legoffic@foss.st.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 09fac5c576bbff764dddf2baca0038b359376fd8
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/st/' for 20250520-hdp-upstream-v2-0-53f6b8b5ffc8@foss.st.com:
arch/arm/boot/dts/st/ste-snowball.dtb: / (calaosystems,snowball-a9500): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 536870912]]}
from schema $id: http://devicetree.org/schemas/root-node.yaml#
arch/arm/boot/dts/st/ste-ux500-samsung-kyle.dtb: /soc/gpio@8000e100: failed to match any schema with compatible: ['stericsson,db8500-gpio', 'st,nomadik-gpio']
prev parent reply other threads:[~2025-05-20 21:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 15:02 Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 1/8] dt-bindings: pinctrl: stm32: Introduce HDP Clément Le Goffic
2025-05-20 19:25 ` Rob Herring (Arm)
2025-05-20 19:37 ` Rob Herring
2025-05-21 8:55 ` Clement LE GOFFIC
2025-05-21 10:31 ` [Linux-stm32] " Amelie Delaunay
2025-05-20 15:02 ` [PATCH v2 2/8] pinctrl: stm32: Introduce HDP driver Clément Le Goffic
2025-05-20 22:34 ` Linus Walleij
2025-05-21 9:49 ` Clement LE GOFFIC
2025-05-21 10:14 ` Clement LE GOFFIC
2025-05-21 21:34 ` kernel test robot
2025-05-20 15:02 ` [PATCH v2 3/8] MAINTAINERS: Add Clément Le Goffic as STM32 HDP maintainer Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 4/8] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13 Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 5/8] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp15 Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 6/8] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp25 Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 7/8] ARM: dts: stm32: add alternate pinmux for HDP pin and add HDP pinctrl node Clément Le Goffic
2025-05-20 15:02 ` [PATCH v2 8/8] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp157c-dk2 board Clément Le Goffic
2025-05-20 21:09 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174777533581.1435243.228426835513916964.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=clement.legoffic@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®