From: Oliver Bock <o.bock@fh-wolfenbuettel.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb-devel@lists.sourceforge.net
Subject: WG: [-mm patch] make drivers/usb/misc/cy7c63.c:vendor_command() static
Date: Thu, 22 Jun 2006 14:06:56 +0200 [thread overview]
Message-ID: <174794175ce6.175ce6174794@fh-wolfenbuettel.de> (raw)
You're right. I'll fix that and resend the current version[1] as a reply
to your message below...
Thanks, Oliver
[1] http://lkml.org/lkml/2006/6/18/128
----- Originalnachricht -----
Von: Adrian Bunk <bunk@stusta.de>
Datum: Donnerstag, Juni 22, 2006 1:37 am
Betreff: [-mm patch] make drivers/usb/misc/cy7c63.c:vendor_command() static
> On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-rc6-mm2:
> >...
> > +gregkh-usb-usb-new-driver-for-cypress-cy7c63xxx-mirco-
> controllers.patch>...
> > USB tree updates
> >...
>
> This patch makes the needlessly global vendor_command() static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.17-mm1-full/drivers/usb/misc/cy7c63.c.old 2006-06-22
> 01:25:08.000000000 +0200
> +++ linux-2.6.17-mm1-full/drivers/usb/misc/cy7c63.c 2006-06-22
> 01:25:57.000000000 +0200
> @@ -63,8 +63,8 @@
> };
>
> /* used to send usb control messages to device */
> -int vendor_command(struct cy7c63 *dev, unsigned char request,
> - unsigned char address, unsigned char
> data) {
> +static int vendor_command(struct cy7c63 *dev, unsigned char request,
> + unsigned char address, unsigned char
> data) {
>
> int retval = 0;
> unsigned int pipe;
>
>
reply other threads:[~2006-06-22 12:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174794175ce6.175ce6174794@fh-wolfenbuettel.de \
--to=o.bock@fh-wolfenbuettel.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®