mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Robin Gong <yibin.gong@nxp.com>,
	 linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	 devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes
Date: Thu, 22 May 2025 15:30:42 -0500	[thread overview]
Message-ID: <174794584287.3722828.5721121369955097366.robh@kernel.org> (raw)
In-Reply-To: <20250522192325.1099680-1-martijn.de.gouw@prodrive-technologies.com>


On Thu, 22 May 2025 21:23:22 +0200, Martijn de Gouw wrote:
> The PCA9450 has support for forced PWM mode on the buck controllers.
> Add support to control this mode.
> 
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
> ---
>  .../bindings/regulator/nxp,pca9450-regulator.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.example.dts:25:18: fatal error: dt-bindings/regulator/nxp,pca9450-regulator.h: No such file or directory
   25 |         #include <dt-bindings/regulator/nxp,pca9450-regulator.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250522192325.1099680-1-martijn.de.gouw@prodrive-technologies.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-05-22 20:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22 19:23 Martijn de Gouw
2025-05-22 19:23 ` [PATCH 2/3] dt-bindings: add bindings for NXP PCA9450 PMIC Martijn de Gouw
2025-05-23  6:53   ` Krzysztof Kozlowski
2025-05-22 19:23 ` [PATCH 3/3] regulator: pca9450: Add support for mode operations Martijn de Gouw
2025-05-22 20:30 ` Rob Herring (Arm) [this message]
2025-05-23  6:52 ` [PATCH 1/3] dt-bindings: regulator: add pca9450: Add regulator-allowed-modes Krzysztof Kozlowski
2025-05-23 10:17 ` Mark Brown
2025-05-23 16:21 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174794584287.3722828.5721121369955097366.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martijn.de.gouw@prodrive-technologies.com \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®