From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: hdegoede@redhat.com,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel-uncore-freq: Fail module load when plat_info is NULL
Date: Mon, 09 Jun 2025 10:52:40 +0300 [thread overview]
Message-ID: <174945556062.2685.13696640320236584390.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250606205300.2384494-1-srinivas.pandruvada@linux.intel.com>
On Fri, 06 Jun 2025 13:53:00 -0700, Srinivas Pandruvada wrote:
> Address a Smatch static checker warning regarding an unchecked
> dereference in the function call:
> set_cdie_id(i, cluster_info, plat_info)
> when plat_info is NULL.
>
> Instead of addressing this one case, in general if plat_info is NULL
> then it can cause other issues. For example in a two package system it
> will give warning for duplicate sysfs entry as package ID will be always
> zero for both packages when creating string for attribute group name.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/intel-uncore-freq: Fail module load when plat_info is NULL
commit: 685f88c72a0c4d12d3bd2ff50286938f14486f85
--
i.
prev parent reply other threads:[~2025-06-09 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 20:53 Srinivas Pandruvada
2025-06-09 7:52 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174945556062.2685.13696640320236584390.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®