mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>,
	 Carlos Bilbao <carlos.bilbao@kernel.org>,
	 Hans de Goede <hdegoede@redhat.com>,
	Jake Hillion <jake@hillion.co.uk>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,  sched-ext@meta.com,
	Blaise Sanouillet <linux@blaise.sanouillet.com>,
	 Suma Hegde <suma.hegde@amd.com>
Subject: Re: [PATCH v2 0/2] x86/platform/amd: better handle scheduling delays in hsmp_send_message
Date: Mon, 09 Jun 2025 10:53:13 +0300	[thread overview]
Message-ID: <174945559319.2685.13353516764058471154.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250605-amd-hsmp-v2-0-a811bc3dd74a@hillion.co.uk>

On Thu, 05 Jun 2025 19:09:25 +0100, Jake Hillion wrote:

> hsmp_send_message currently relies in 2 places on the assumption that
> usleep_range will complete in well under 100ms. This is not guaranteed,
> and is prevalent when running sched_ext schedulers or possible under
> other high load conditions.
> 
> These patches alter the behaviour in two ways:
> 1. Checks the result of `mbox_status` a final time if the sleep took us
>    past the timeout. This gives a useful result under test when there
>    are significant scheduling delays, rather than -ETIMEDOUT.
> 2. Removes the 100ms limit on awaiting the semaphore. This allows a
>    second thread to compete even when the other suffers large scheduling
>    delays.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] x86/platform/amd: move final timeout check to after final sleep
      commit: f8afb12a2d7503de6558c23cacd7acbf6e9fe678
[2/2] x86/platform/amd: replace down_timeout with down_interruptible
      commit: 784e48a82976ee0b645788750343cd1b28a372f3

--
 i.


      parent reply	other threads:[~2025-06-09  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 18:09 Jake Hillion via B4 Relay
2025-06-05 18:09 ` [PATCH v2 1/2] x86/platform/amd: move final timeout check to after final sleep Jake Hillion via B4 Relay
2025-06-05 18:09 ` [PATCH v2 2/2] x86/platform/amd: replace down_timeout with down_interruptible Jake Hillion via B4 Relay
2025-06-09  7:53 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174945559319.2685.13353516764058471154.b4-ty@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=carlos.bilbao@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=jake@hillion.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@blaise.sanouillet.com \
    --cc=naveenkrishna.chatradhi@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sched-ext@meta.com \
    --cc=suma.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®