mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	 Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Kan Liang <kan.liang@linux.intel.com>,
	James Clark <james.clark@linaro.org>,
	 Dapeng Mi <dapeng1.mi@linux.intel.com>,
	 Thomas Richter <tmricht@linux.ibm.com>,
	 Veronika Molnarova <vmolnaro@redhat.com>,
	Chun-Tse Shao <ctshao@google.com>,  Leo Yan <leo.yan@arm.com>,
	Hao Ge <gehao@kylinos.cn>,  Howard Chu <howardchu95@gmail.com>,
	Weilin Wang <weilin.wang@intel.com>,
	 Levi Yun <yeoreum.yun@arm.com>,
	 "Dr. David Alan Gilbert" <linux@treblig.org>,
	 Gautam Menghani <gautam@linux.ibm.com>,
	 Tengda Wu <wutengda@huaweicloud.com>,
	linux-perf-users@vger.kernel.org,  linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org,  Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v4 00/10] Move uid filtering to BPF filters
Date: Tue, 10 Jun 2025 11:38:59 -0700	[thread overview]
Message-ID: <174958073941.4039944.6156587445391341437.b4-ty@kernel.org> (raw)
In-Reply-To: <20250604174545.2853620-1-irogers@google.com>

On Wed, 04 Jun 2025 10:45:34 -0700, Ian Rogers wrote:
> Rather than scanning /proc and skipping PIDs based on their UIDs, use
> BPF filters for uid filtering. The /proc scanning in thread_map is
> racy as the PID may exit before the perf_event_open causing perf to
> abort. BPF UID filters are more robust as they avoid the race. The
> /proc scanning also misses processes starting after the perf
> command. Add a helper for commands that support UID filtering and wire
> up. Remove the non-BPF UID filtering support given it doesn't work.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung



      parent reply	other threads:[~2025-06-10 18:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 17:45 Ian Rogers
2025-06-04 17:45 ` [PATCH v4 01/10] perf parse-events filter: Use evsel__find_pmu Ian Rogers
2025-06-04 17:45 ` [PATCH v4 02/10] perf target: Separate parse_uid into its own function Ian Rogers
2025-06-04 17:45 ` [PATCH v4 03/10] perf parse-events: Add parse_uid_filter helper Ian Rogers
2025-06-06 17:41   ` Namhyung Kim
2025-06-06 18:13     ` Ian Rogers
2025-06-06 20:01       ` Namhyung Kim
2025-06-04 17:45 ` [PATCH v4 04/10] perf record: Switch user option to use BPF filter Ian Rogers
2025-06-04 17:45 ` [PATCH v4 05/10] perf tests record: Add basic uid filtering test Ian Rogers
2025-06-04 17:45 ` [PATCH v4 06/10] perf top: Switch user option to use BPF filter Ian Rogers
2025-06-04 17:45 ` [PATCH v4 07/10] perf trace: " Ian Rogers
2025-06-04 17:45 ` [PATCH v4 08/10] perf bench evlist-open-close: " Ian Rogers
2025-06-04 17:45 ` [PATCH v4 09/10] perf target: Remove uid from target Ian Rogers
2025-06-04 17:45 ` [PATCH v4 10/10] perf thread_map: Remove uid options Ian Rogers
2025-06-06  2:44 ` [PATCH v4 00/10] Move uid filtering to BPF filters Namhyung Kim
2025-06-10 18:38 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174958073941.4039944.6156587445391341437.b4-ty@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=ctshao@google.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=gautam@linux.ibm.com \
    --cc=gehao@kylinos.cn \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    --cc=vmolnaro@redhat.com \
    --cc=weilin.wang@intel.com \
    --cc=wutengda@huaweicloud.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®