From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Patrisious Haddad <phaddad@nvidia.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Christian Göttsche" <cgzones@googlemail.com>,
"Serge Hallyn" <serge@hallyn.com>,
"Chiara Meiohas" <cmeiohas@nvidia.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw_cleanup
Date: Thu, 12 Jun 2025 05:05:29 -0400 [thread overview]
Message-ID: <174971912969.3783933.11490887989460650891.b4-ty@kernel.org> (raw)
In-Reply-To: <20250610092846.2642535-1-arnd@kernel.org>
On Tue, 10 Jun 2025 11:28:42 +0200, Arnd Bergmann wrote:
> This function has an array of eight mlx5_async_cmd structures, which
> often fits on the stack, but depending on the configuration can
> end up blowing the stack frame warning limit:
>
> drivers/infiniband/hw/mlx5/devx.c:2670:6: error: stack frame size (1392) exceeds limit (1280) in 'mlx5_ib_ufile_hw_cleanup' [-Werror,-Wframe-larger-than]
>
> Change this to a dynamic allocation instead. While a kmalloc()
> can theoretically fail, a GFP_KERNEL allocation under a page will
> block until memory has been freed up, so in the worst case, this
> only adds extra time in an already constrained environment.
>
> [...]
Applied, thanks!
[1/1] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw_cleanup
https://git.kernel.org/rdma/rdma/c/b26852daaa83f5
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2025-06-12 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:28 Arnd Bergmann
2025-06-10 9:50 ` Patrisious Haddad
2025-06-10 10:31 ` Arnd Bergmann
2025-06-10 14:51 ` Patrisious Haddad
2025-06-12 9:05 ` Leon Romanovsky
2025-06-12 9:05 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174971912969.3783933.11490887989460650891.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cgzones@googlemail.com \
--cc=cmeiohas@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=phaddad@nvidia.com \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®