From: Lee Jones <lee@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Arnd Bergmann <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Lee Jones" <lee@kernel.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Kevin Hilman" <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Chen Ni" <nichen@iscas.ac.cn>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: (subset) [PATCH] mfd: fix building without CONFIG_OF
Date: Thu, 12 Jun 2025 11:01:56 +0100 [thread overview]
Message-ID: <174972251660.411546.11712272234120780.b4-ty@kernel.org> (raw)
In-Reply-To: <20250520154106.2019525-1-arnd@kernel.org>
On Tue, 20 May 2025 17:40:43 +0200, Arnd Bergmann wrote:
> Using the of_fwnode_handle() means that local 'node' variables are unused
> whenever CONFIG_OF is disabled for compile testing:
>
> drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> drivers/mfd/88pm860x-core.c:576:29: error: unused variable 'node' [-Werror=unused-variable]
> 576 | struct device_node *node = i2c->dev.of_node;
> | ^~~~
> drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
> drivers/mfd/max8925-core.c:659:29: error: unused variable 'node' [-Werror=unused-variable]
> 659 | struct device_node *node = chip->dev->of_node;
> | ^~~~
> drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
> drivers/mfd/twl4030-irq.c:679:46: error: unused variable 'node' [-Werror=unused-variable]
> 679 | struct device_node *node = dev->of_node;
> | ^~~~
>
> [...]
Applied, thanks!
[1/1] mfd: fix building without CONFIG_OF
commit: fc5f017a71d08eea3983762ce57d27e5bc300db1
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-06-12 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 15:40 Arnd Bergmann
2025-05-22 5:57 ` Jiri Slaby
2025-06-12 10:01 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174972251660.411546.11712272234120780.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=rogerq@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®