From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbWEEWKg (ORCPT ); Fri, 5 May 2006 18:10:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751793AbWEEWKg (ORCPT ); Fri, 5 May 2006 18:10:36 -0400 Received: from ozlabs.org ([203.10.76.45]:23429 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1751790AbWEEWKf (ORCPT ); Fri, 5 May 2006 18:10:35 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17498.60066.92373.6527@cargo.ozlabs.ibm.com> Date: Fri, 5 May 2006 16:03:14 +1000 From: Paul Mackerras To: Arnd Bergmann Cc: cbe-oss-dev@ozlabs.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Geoff Levand , Arnd Bergmann Subject: Re: [PATCH 04/13] cell: remove broken __setup_cpu_be function In-Reply-To: <20060429233920.295209000@localhost.localdomain> References: <20060429232812.825714000@localhost.localdomain> <20060429233920.295209000@localhost.localdomain> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > From: Geoff Levand > > This patch removes the incorrect Cell processor setup routine > __setup_cpu_be. This routine improperly accesses the hypervisor > page size configuration at SPR HID6. The correct behavior is for > firmware, or if needed, platform setup code, to set the correct > page size. > - .cpu_setup = __setup_cpu_be, > + .cpu_setup = __setup_cpu_power4, That looks a bit dodgy. Either just remove the contents of __setup_cpu_be (leaving only the blr), or define a __setup_cpu_null that does nothing, or make the identify_cpu not call the cpu setup function if the pointer is NULL. Paul.