mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: Harinath Nampally <harinath922@gmail.com>, jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, amsfield22@gmail.com
Subject: Re: [PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability
Date: Sun, 5 Nov 2017 21:36:01 +0100	[thread overview]
Message-ID: <174aea53-99b0-e400-c2f3-8a7a9fd809d8@posteo.de> (raw)
In-Reply-To: <1509904804-4608-3-git-send-email-harinath922@gmail.com>

On 2017-11-05 19:00, Harinath Nampally wrote:
> Rename structs holding event configuration registers
> to more appropriate names. This naming is consistent
> with the event config register names given in the
> mma845x and fxls8471 datasheets.
> 
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>

Makes sense to me.

Acked-by: Martin Kepplinger <martink@posteo.de>


Hey Harinath,

I think it'd be great to have the "power_mode" iio ABI interface
for mma8452 too, and I just found an old patch pf mine for this.

If you say you could test it and check for correct API usage and
ABI provisioning in sysfs, I'd be happy to publish it for you to
make any necessary corrections and submit it after testing.

Do we have a deal?

thanks

                             martin

  reply	other threads:[~2017-11-05 20:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 18:00 [PATCH v4 0/2] Refactor event related code Harinath Nampally
2017-11-05 18:00 ` [PATCH v4 1/2] iio: accel: mma8452: Rename a struct for code readibility Harinath Nampally
2017-11-05 20:36   ` Martin Kepplinger
2017-11-19 14:57     ` Jonathan Cameron
2017-11-05 18:00 ` [PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability Harinath Nampally
2017-11-05 20:36   ` Martin Kepplinger [this message]
2017-11-06  1:04     ` harinath Nampally
2017-11-19 14:59     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174aea53-99b0-e400-c2f3-8a7a9fd809d8@posteo.de \
    --to=martink@posteo.de \
    --cc=amsfield22@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=harinath922@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome