From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750968AbdA0XeB (ORCPT ); Fri, 27 Jan 2017 18:34:01 -0500 Received: from mout.gmx.net ([212.227.15.15]:52048 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdA0Xdu (ORCPT ); Fri, 27 Jan 2017 18:33:50 -0500 Subject: Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails To: Netanel Belgazal , linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org References: <1485469096-5271-1-git-send-email-netanel@annapurnalabs.com> <1485469096-5271-3-git-send-email-netanel@annapurnalabs.com> Cc: dwmw@amazon.com, zorik@annapurnalabs.com, alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com, aliguori@amazon.com, nafea@annapurnalabs.com, eric.dumazet@gmail.com From: Lino Sanfilippo Message-ID: <174cba24-4bf4-4212-9756-2bedf4fa5a92@gmx.de> Date: Sat, 28 Jan 2017 00:33:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1485469096-5271-3-git-send-email-netanel@annapurnalabs.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:BweD1+hqMbVjhclF5CHG8a/YyjBbWTNdDiKxyPHngHEKUUK4nk/ gCZ1aJQoZrgzbSLegn0U6lUnXG47RF6XxQdn398RctjgxI7hR1JTysIVkDot1l5QZxH1WlW 9WDY31nYPWoZORTnzYgRqDdbOPoNincG8Tou1R8mvCAFHN7Z576ky7CNPj5hMvK2+vCbDNW KL657yK92Vw2ybEZXQDDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:tPaXh4pc/qo=:yypQtnn//ZEcAIHbwc8LKU 6dbkb6KcFkBkiU8KDKe3ou8Gc6OYL4OSualee7Z+ylSB2/R5sfBsuHuv40GWeoOZxYXbpYcQX nVE7JmynLo13m67j66Mvv1ajCV8KM467PG6w/Dpr2kNyhnSnqJc24Uk/tuLKIvzLH8Zh1yDxM I6taJNnyzyPhLVUaBMmdd/KZpsA2JH9ClfD7o49wcZrZaMH6uWIeQyTxsyZYD980wIRQLfkX3 hhizMPlWyxsuN4Dmnh2YBrQNWqpqgU4wVOkPsaHkbvHm9DZH61kZIwOmZq1z5f4Rn3+Xxmhj9 NledUWrL87VfNrxyvDg8iM9OIqGRHOypnQBvBbcx+9LFYX7/gPHmYxJUlBhewhEeRk1lDWONk a1Xpf/vf+5PBwFYueImow2s8fClTbYUoy7qUJAa2zrxpfIRTIzln6yS2r8C9Pk6StqF62hNtp +DlcNUyASDw5xHoLpQFokv/TSBjTdDG4PgWVun0vjPhIXbhu63tZXfycQrKxhDZYu6SECNBKW U4CyRb0nttmaFdOk2IhjkFJS7cdqCchddNkc+nplqBAsC/V4/+p3IVomFAfCE+WV3B8Eo+27w 32OenjyylMF9IMCQ/qc4SZq3irKYv0bGjdKxrNQg+Ozu0Rdbeg2KDgwqJBWepiw7p99uAjCdX /TqA455C/nNB+iPhQ10XJ2mIcVawC8em3ocaKK12phHdDZH/Wpo/zeFEWMLJuM5Vb+h1A6xss CQxWsjmtLtfHL5lBnmwWsMpK0L6SFnon5N9t7asSCt2Y5GqWGEceoh8N1ZE4FihgyyzocHtsh OMREWLf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 26.01.2017 23:18, Netanel Belgazal wrote: > When driver fails in probe, it will release all resources, > including adapter. > In case of probe failure, ena_remove should not try to > free the adapter resources. > > Signed-off-by: Netanel Belgazal > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index 7493ea3..cb60567 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -3046,6 +3046,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > err_free_region: > ena_release_bars(ena_dev, pdev); > err_free_ena_dev: > + pci_set_drvdata(pdev, NULL); > vfree(ena_dev); > err_disable_device: > pci_disable_device(pdev); > Is this change really a "fix"? remove() should only be called if probe() has been successful before, otherwise not. Did you experience something different? Regards, Lino