From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbdFPGt6 (ORCPT ); Fri, 16 Jun 2017 02:49:58 -0400 Received: from mga07.intel.com ([134.134.136.100]:65137 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbdFPGt5 (ORCPT ); Fri, 16 Jun 2017 02:49:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,346,1493708400"; d="scan'208";a="981553283" Subject: Re: [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array To: Kim Phillips , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Andi Kleen Cc: linux-kernel@vger.kernel.org References: <20170615125514.58399e95ea099fdec244b36f@arm.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <174ce49b-d0f9-9c0c-013e-d110a0494b41@intel.com> Date: Fri, 16 Jun 2017 09:43:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170615125514.58399e95ea099fdec244b36f@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/17 20:55, Kim Phillips wrote: > > Signed-off-by: Kim Phillips Looks like defines for sampling support that got mixed in with earlier patches. We can always put them back when we need them, so: Acked-by: Adrian Hunter > --- > tools/perf/arch/x86/util/intel-bts.c | 4 ---- > tools/perf/arch/x86/util/intel-pt.c | 4 ---- > tools/perf/util/intel-bts.c | 2 -- > 3 files changed, 10 deletions(-) > > diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c > index af2bce7a2cd6..781df40b2966 100644 > --- a/tools/perf/arch/x86/util/intel-bts.c > +++ b/tools/perf/arch/x86/util/intel-bts.c > @@ -35,10 +35,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60) > - > struct intel_bts_snapshot_ref { > void *ref_buf; > size_t ref_offset; > diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c > index f630de0206a1..6fe667b3269e 100644 > --- a/tools/perf/arch/x86/util/intel-pt.c > +++ b/tools/perf/arch/x86/util/intel-pt.c > @@ -40,10 +40,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60) > - > #define INTEL_PT_PSB_PERIOD_NEAR 256 > > struct intel_pt_snapshot_ref { > diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c > index b2834ac7b1f5..218ee2bac9a5 100644 > --- a/tools/perf/util/intel-bts.c > +++ b/tools/perf/util/intel-bts.c > @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish) > fprintf(stdout, intel_bts_info_fmts[i], arr[i]); > } > > -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE]; > - > int intel_bts_process_auxtrace_info(union perf_event *event, > struct perf_session *session) > { >