From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48DF32D9ED9 for ; Tue, 17 Jun 2025 12:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750162328; cv=none; b=Sfx4J+xGu20gpoyjzm3ipYwSbFNcDWF3TI0KsAtCp3c9rkZoJGZF7ALnyOnzurU5Et+v2XfVlizOQmklkiHEtvATt9wa1xR7m6vcHdQznul3pdfZh+DVCiA+etS0nrAmotq777NZz2G0bn/cbVvPv5t99mPni9v3ev64QK9TfQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750162328; c=relaxed/simple; bh=jtjGkx7PbcE2vHDnfHVl0N+SZYB2VE9WYKDSXkb4WjQ=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=e0KMuwIXJtRA4rLFDbFrH97+luIhHQPFMFn//B8iQ74vCnk05KUR93VXXzoY8yfQCh/ciwaR2rY+75s+cTzG4XKrxlgkcoYn7YyB3nx/SiyN2diZ+5LiBK6OUmyiNJiUwHoQme7gbr714tFuEIdbr7utjP1uQGpu+Yu24PGjr0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=mGmT086r; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="mGmT086r" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-875acfc133dso179848539f.1 for ; Tue, 17 Jun 2025 05:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1750162325; x=1750767125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:from:to:cc:subject:date:message-id :reply-to; bh=f/qjREJUOIJxRz7QxQVVE+iucFdBwBB5lgjEmSZXzLo=; b=mGmT086rDSv7DqoRsYsm4hr01t+EewawRqPgaSFQ7wJ8WbFVCNAgAXCiF8xgAAX3sc pdQILmDjv45bpSIS+NgKuIoSZ/cNchEEr7GO8ILikEADqb4iXlk5LHssXe0/Eyt5lI7B v3KOFuX+CJ0RC4pT3fOI53UICL/+eJOGvTZ/w3uCe0J5g7MbPF0QOwexLd1jyjNU9CzB JQEcOrdfA0EPcaxWrOJqwdwpiavmBJ7yQeOLLxVi8UKhyrIeT8iVjSi7G4L95Qf9lQgu XAtuvf7HLPdHAE0R/hkoeIEi2Bno+KqGPCG6nFerdz1P3INH3Xef3FZQdY1fDLYepG3A IGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750162325; x=1750767125; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f/qjREJUOIJxRz7QxQVVE+iucFdBwBB5lgjEmSZXzLo=; b=GPGLyuQF0XfZAsHOC2H0rkLTgKjkUOzTQLaHK5Ouedj8R9SPhNYJ1kFdbIPUopA/+C EHLHoqSGQ7NikbrQojtwkWaBuKoHblrUz88S/CNYCWQO7n3vmudBayIV/8BLS8NrVcBA 0V/ytp8xWbTOkIBCvewIWXUlHy7ueirxkY32pnCnP8KxCL9C++JzqaPV8SPA6rFcqAng ERc5+YSS75hiUYT3J0QoBMKZ1xol/U60HcT19GKewONlZeRJgNK6PaAF1wKeNkBPU9hs GST+ICSF7jwfTiDW3NGSlOS0PM6aM+m2CEhGaKvzdkD1sp3MyL6kaBXM4W/RyoLQATgg vxNw== X-Forwarded-Encrypted: i=1; AJvYcCUUaLX6igOwkVvY8QhEL5XRXEQUm8egwt0/3wsVNyXqJ9sSJ7Q71WuV5i+saEnOS4lXwGu/AxKKdQBwqUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyaKvxZQWcJbYr8+PhwwslII9/ZyiXr7rV8JqgXWyiL24XXOkc3 4GwrZ+a5NezeRdv1ZicGYkrKPsc2GeZXjdLTV5CHDClj7nnnNtcq9+igRRqKvf7N7S2/oPs4Tpo pWN+D X-Gm-Gg: ASbGncudxW1/KynHfr5QPztSD2/NG8t0Vqiyf2+KVx0laRhWU4OJAzCr0pGYi4s1KC+ QOMMomuV+u2pTgmytoi4+cClTvvdV7IPh9n4mukvUW8kvZdleI4uJQ2mE59vaov7fVcWt5c1AzH GJVKM5Te8ThizpkFEgLXdSWxoKpymkgKC0dRa4nE9jeHfNcjkVR8qDV4vM1dhKBufu/eizoghlj yvcPnSMhf0glV2ORaebOgC5U6pq+QtQr0LaUvlU22x8SOzm1NjCh/EYGYGixpSHt5vjT1UhQO32 gFLygwvRq69VticvqY6muhk6HXrF8cfhyjclZ7dOS+pAuHRN3AfSJQ== X-Google-Smtp-Source: AGHT+IG0w7oJnEhc9SyJVK6zFLHv3cqGyVrecWmvAPvfn0VzcgjB1pecE+hhN3zMhmzyPcnm5FRGeQ== X-Received: by 2002:a05:6e02:184a:b0:3db:7c22:303c with SMTP id e9e14a558f8ab-3de07cfe991mr128241535ab.8.1750162324822; Tue, 17 Jun 2025 05:12:04 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3de01a502b8sm24901745ab.66.2025.06.17.05.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:12:04 -0700 (PDT) From: Jens Axboe To: ed.cashin@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Justin Sanders In-Reply-To: <20250610170600.869-1-jsanders.devel@gmail.com> References: <20250610170600.869-1-jsanders.devel@gmail.com> Subject: Re: [PATCH 1/2] aoe: clean device rq_list in aoedev_downdev() Message-Id: <175016232389.1144398.4390914425439308132.b4-ty@kernel.dk> Date: Tue, 17 Jun 2025 06:12:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-d7477 On Tue, 10 Jun 2025 17:05:59 +0000, Justin Sanders wrote: > An aoe device's rq_list contains accepted block requests that are > waiting to be transmitted to the aoe target. This queue was added as > part of the conversion to blk_mq. However, the queue was not cleaned out > when an aoe device is downed which caused blk_mq_freeze_queue() to sleep > indefinitely waiting for those requests to complete, causing a hang. This > fix cleans out the queue before calling blk_mq_freeze_queue(). > > [...] Applied, thanks! [1/2] aoe: clean device rq_list in aoedev_downdev() commit: a847c4a41630b38136e069aad82dd619c03e95b6 [2/2] aoe: defer rexmit timer downdev work to workqueue commit: 71437cf6208c63af6ba99cb42074d13d7b56b669 Best regards, -- Jens Axboe