From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6010E345738 for ; Thu, 19 Mar 2026 18:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946236; cv=none; b=D8/MN6beUlOSwCemQaDBhYDPPb35m3dsC25oqo2LYvmgC7H1+zEzEUqz4afZzsch9uZ7DR4UUyO9xyzsWepsNiqc8Uc0K18oM0oaIQyNXHrZZ32xR46dxc7EdiOV1TyCLvrd5BUqta0BcxS9BCiS3YGvOWEleUHIArZlKHOiwA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946236; c=relaxed/simple; bh=gr/9NeEAFUkbVQbfw4Mz4GNhFZSSp1BkHRJt9tIUqz4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U0PIg8+ueH8JbXsqMW6ohHSNSH1+9Hfp/rAUAOONwNoQjjmKQd2019jsL7xHwu+PWJhvqjgXzP0PXFF13B6TO7KRYCZF2AT6+uYlz33RMq5PTolAOABZOQeALovB1j7CrLhzEzmj7coA03vfCggL2DyEai4ZyhXY+eeku4ZXCpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YSopD4qg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H7Mh6joC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YSopD4qg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H7Mh6joC" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62JEVF003368474 for ; Thu, 19 Mar 2026 18:50:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gr/9NeEAFUkbVQbfw4Mz4GNhFZSSp1BkHRJt9tIUqz4=; b=YSopD4qgHwbIVIpz oqUx2FZRfeiSp7FyrEuC83/50T28HT1CW/+rdOV51TEMTWaSNRq9bzKd1MhOCm4J exV3MwIj+etMLmexHrYnot72cf4c2CK5T/atE43P/CqkUbchc26SJNtKSlrAse+8 Q/zuMIynH442jCSbWYEOeIeJyHf5RtdxYX8vLcKkfVwUYZjlrPMGDc3sveQ7367I zXzE4So2vvHPQAtkA4GzJ4pOfbjiXQRlgcv71fT8gzfuC/UETr66Rgh1pQP2whqO /eEpqAt+JrvAP/J8Mv2tpxuEZw0eIFebSnta3takZmBbelOCBQD29h3o6hWD4L+T 0MMUzA== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d00f9mdxa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 18:50:34 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2bdd327d970so711446eec.1 for ; Thu, 19 Mar 2026 11:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773946233; x=1774551033; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gr/9NeEAFUkbVQbfw4Mz4GNhFZSSp1BkHRJt9tIUqz4=; b=H7Mh6joCJ/H1sjDeT5PXpC4yDNnZVyKGegg8qigTKeCGbWVvZ5ia/pqnjRSgIiBUzX irqSyEYoPhVHKTWE47bAzzE1exc3inq61KKN1MxVWfd8dXEoA/m1k0T5uvvutSexY5vd WM5UXgcOcGbiK45ufsvW180uGxXIlzgs1281Y1Q8msGm7pCq+XSzAA9KwRplDfbd+FBW SuFs5Npgcj3ObHG6eV+C+1MeYMZjPPS1znE9cCm+7kjRErGsXNaHYNNZWljgWxVX+8hR Fd+IRsdrnUY/4C2omfyic5k6JFoiZcFWkDFVL2bMXged3mWCVeBX6sb83v63xYmNGbQA R/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946233; x=1774551033; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gr/9NeEAFUkbVQbfw4Mz4GNhFZSSp1BkHRJt9tIUqz4=; b=nv0HOl0vqb/Wz/1gugk/HVsWwvz+AaF0aMVZOcmYr9fy1OaY355CMbp1eqVBUUPu7R Fw4HuywmsxgsYrLT4o+Lr5sx/WsI8ZkbRRmtbHgGYlr0fTWCH/Bqgxb9h2cE2fJxclzK ENvJ/JDiG/jlsYpMjzk+Xd3JOmVMmHCMMe23lVCqrUzygJ5uRr4uJzIn03T9jiL+lJVv NE2AEIeaVnvuMDA3NDAOsdsepDHcVP1Nohkd+6AetdbbQRCJEyCUXasr8f1JKlbZ4Hly m2aDINQ9aA96K/8SrpDTHUCg3QF/RAqlL+zNyl2URRU7C1ffImy4HVYvLN+/o6dWJ+/b Ogyg== X-Forwarded-Encrypted: i=1; AJvYcCUclgbENWWQMCAVr6srNsOCZ1Zpn4nIMNyEY+FB6QeydkKWcaUzUMO9lQ4/sthDv26JEyg8QtD2iGeqxIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxAIJkBKqtGTMpIV/Tr4PCRiwi1MUH2weuyOqodsjGdR8oypzUf Rb8TPUCmRD+WHn7GSVd+uJNA2G7ZLVPV3DV/mxnYEQVkMftkTusJ3Fq2Wpd7UW74Hk7H5aHlvYs 0iTzSfmboVdUfPr1eJD+FqDpJQrmQ3LbGkFW8623b6mL/8dax01p9DM9a6CZJlCWChHo= X-Gm-Gg: ATEYQzzSs3m4qOpW3EiIrgasH0/Foh2yzkpad8FONIEzbSbydvlXnyoUH/G8bGkUt1R C+2reqCiDWsCmBBE56IzlwP3MvxCRdDQRnMMJzjLQpPmdTG5M3ldBmW41S5tZqF6l7OvCXi4/Ad lDwOY4N/FRH2BggizKOy+SE4fdT8hhqsE2fsdMFBYlqdVmH8NeIIOWyvOrTFhuvh+qxYDAZrzHo KaF4THtKVwclSmH9huk90Coa9DU7shsCUCwHIhK1bncxMHdvuiZ6KaH/RcBwFYRdcwgpCuiwFL0 Z0Ncnew6HE/M+0rK6Hq61n354USeMikztyKFRVQVeeJr120LjABuUsfRfiJ5ir85IYOHHl/RjyK TSK1mj1tGLThNmPaPEP04itN14GifrXgb9AzgItlcUentDXM1dzWtLxLR2L8rC0W0y4D9AVIKqs 2eI6Y++eDtweKnvg== X-Received: by 2002:a05:7300:fb8d:b0:2c0:ca48:3107 with SMTP id 5a478bee46e88-2c0f3eb5664mr1959238eec.15.1773946233170; Thu, 19 Mar 2026 11:50:33 -0700 (PDT) X-Received: by 2002:a05:7300:fb8d:b0:2c0:ca48:3107 with SMTP id 5a478bee46e88-2c0f3eb5664mr1959219eec.15.1773946232576; Thu, 19 Mar 2026 11:50:32 -0700 (PDT) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e536894bsm10154217eec.5.2026.03.19.11.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 11:50:31 -0700 (PDT) Message-ID: <17507b59-c688-4a3c-9eb5-a907e297a10a@oss.qualcomm.com> Date: Thu, 19 Mar 2026 11:50:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] wifi: iwlwifi: pcie: migrate to modern pci_alloc_irq_vectors API To: =?UTF-8?Q?Adri=C3=A1n_Garc=C3=ADa_Casado?= , Miri Korenblit Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Miguel Ojeda References: <20260319182925.19436-1-adriangarciacasado42@gmail.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20260319182925.19436-1-adriangarciacasado42@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDE1MSBTYWx0ZWRfX/7sd0ElzcE4F AhqM4auUKKHNqP8sufpre/kA+/wT2V6JZUAc8lQxtqyaWx1Q/oaezcWNjZBHcdo+QJIwNUdZ4LG rYmFY1OsdHPG3giF6OeE8UNQu3l6MyeTPodmKKOAdDgul5TF5g2jdXewjgMVIJ1rkx7vzi9tHbg 7OOZ74SdvWg1bWjEfSB4yPdVPcHzdGFxTh7qgKCcmPOxvemWQqT87T0v1pZO/PWyxOkog0eKKX3 UhPHbdyxsVrYhxcrQvItRSpfHFaa+ByQhcii7kUGy1dw6MwoZ9Smt+RVjvgkUrVXLoDfuIxnlyS CzABMEhn3erXSJRwr2lfE12cxYHvQMvuE8mh/GXahkSR+G4JOcHrZsEGqXphqM5wHFL/Ps7dozw u/Mo848lBOFA9KJzY0a1d1odKbBEqhZRo5eLsNmXr/lJzQ3QlmusNJEF+NfT3lSiCOwEcMOLIJ1 eFSTPM//kNb67zx6p6w== X-Proofpoint-GUID: fffbmR_ymYNdQ4CbAag6bXMIHiOzWUBv X-Proofpoint-ORIG-GUID: fffbmR_ymYNdQ4CbAag6bXMIHiOzWUBv X-Authority-Analysis: v=2.4 cv=MJttWcZl c=1 sm=1 tr=0 ts=69bc457a cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=jSEP3iq8ptvKKmpwVf0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_03,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190151 On 3/19/2026 11:29 AM, Adrián García Casado wrote: > Johannes Berg suggested using pci_alloc_irq_vectors() and delegating > affinity management to the kernel. This patch replaces > pci_enable_msix_range() with the modern API and leverages > PCI_IRQ_AFFINITY. The manual affinity loop is removed as it's now > redundant. I see from the archive that you've been pointed to this link, but I'm going to do so again... https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes "Describe your problem. Whether your patch is a one-line bug fix or 5000 lines of a new feature, there must be an underlying problem that motivated you to do this work. Convince the reviewer that there is a problem worth fixing and that it makes sense for them to read past the first paragraph." "Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour."