From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Mostafa Saleh <smostafa@google.com>
Cc: oliver.upton@linux.dev, joey.gouly@arm.com,
suzuki.poulose@arm.com, yuzenghui@huawei.com,
catalin.marinas@arm.com, will@kernel.org, qperret@google.com
Subject: Re: [PATCH v2] KVM: arm64: Fix error path in init_hyp_mode()
Date: Thu, 26 Jun 2025 08:53:27 +0100 [thread overview]
Message-ID: <175092440336.8068.17654803423983782262.b4-ty@kernel.org> (raw)
In-Reply-To: <20250625123058.875179-1-smostafa@google.com>
On Wed, 25 Jun 2025 12:30:58 +0000, Mostafa Saleh wrote:
> In the unlikely case pKVM failed to allocate carveout, the error path
> tries to access NULL ptr when it de-reference the SVE state from the
> uninitialized nVHE per-cpu base.
>
> [ 1.575420] pstate: 61400005 (nZCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
> [ 1.576010] pc : teardown_hyp_mode+0xe4/0x180
> [ 1.576920] lr : teardown_hyp_mode+0xd0/0x180
> [ 1.577308] sp : ffff8000826fb9d0
> [ 1.577600] x29: ffff8000826fb9d0 x28: 0000000000000000 x27: ffff80008209b000
> [ 1.578383] x26: ffff800081dde000 x25: ffff8000820493c0 x24: ffff80008209eb00
> [ 1.579180] x23: 0000000000000040 x22: 0000000000000001 x21: 0000000000000000
> [ 1.579881] x20: 0000000000000002 x19: ffff800081d540b8 x18: 0000000000000000
> [ 1.580544] x17: ffff800081205230 x16: 0000000000000152 x15: 00000000fffffff8
> [ 1.581183] x14: 0000000000000008 x13: fff00000ff7f6880 x12: 000000000000003e
> [ 1.581813] x11: 0000000000000002 x10: 00000000000000ff x9 : 0000000000000000
> [ 1.582503] x8 : 0000000000000000 x7 : 7f7f7f7f7f7f7f7f x6 : 43485e525851ff30
> [ 1.583140] x5 : fff00000ff6e9030 x4 : fff00000ff6e8f80 x3 : 0000000000000000
> [ 1.583780] x2 : 0000000000000000 x1 : 0000000000000002 x0 : 0000000000000000
> [ 1.584526] Call trace:
> [ 1.584945] teardown_hyp_mode+0xe4/0x180 (P)
> [ 1.585578] init_hyp_mode+0x920/0x994
> [ 1.586005] kvm_arm_init+0xb4/0x25c
> [ 1.586387] do_one_initcall+0xe0/0x258
> [ 1.586819] do_initcall_level+0xa0/0xd4
> [ 1.587224] do_initcalls+0x54/0x94
> [ 1.587606] do_basic_setup+0x1c/0x28
> [ 1.587998] kernel_init_freeable+0xc8/0x130
> [ 1.588409] kernel_init+0x20/0x1a4
> [ 1.588768] ret_from_fork+0x10/0x20
> [ 1.589568] Code: f875db48 8b1c0109 f100011f 9a8903e8 (f9463100)
> [ 1.590332] ---[ end trace 0000000000000000 ]---
>
> [...]
Applied to fixes, thanks!
[1/1] KVM: arm64: Fix error path in init_hyp_mode()
commit: 9a2b9416fd1d18d97ce1b737a11fcbc521140e5d
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2025-06-26 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 12:30 Mostafa Saleh
2025-06-25 12:35 ` Quentin Perret
2025-06-26 7:53 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175092440336.8068.17654803423983782262.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=qperret@google.com \
--cc=smostafa@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®