From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Yi Sun <yi.sun@intel.com>
Cc: gordon.jin@intel.com, yi.sun@linux.intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>
Subject: Re: [PATCH v2] dmaengine: idxd: Remove __packed from structures
Date: Thu, 26 Jun 2025 15:48:11 -0700 [thread overview]
Message-ID: <175097809157.79884.15067500318866840512.b4-ty@kernel.org> (raw)
In-Reply-To: <20250404053614.3096769-1-yi.sun@intel.com>
On Fri, 04 Apr 2025 13:36:14 +0800, Yi Sun wrote:
> The __packed attribute introduces potential unaligned memory accesses
> and endianness portability issues. Instead of relying on compiler-specific
> packing, it's much better to explicitly fill structure gaps using padding
> fields, ensuring natural alignment.
>
> Since all previously __packed structures already enforce proper alignment
> through manual padding, the __packed qualifiers are unnecessary and can be
> safely removed.
>
> [...]
Applied, thanks!
[1/1] dmaengine: idxd: Remove __packed from structures
commit: 671a654aecc710a278bdd30cfd2afef2d4e0828f
Best regards,
--
~Vinod
next prev parent reply other threads:[~2025-06-26 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 5:36 Yi Sun
2025-05-15 13:45 ` Yi Sun
2025-06-26 22:48 ` Vinod Koul [this message]
2025-06-27 4:05 ` Andy Shevchenko
2025-06-27 6:30 ` Yi Sun
2025-06-27 6:57 ` Andy Shevchenko
2025-06-27 7:15 ` Yi Sun
2025-06-27 17:55 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175097809157.79884.15067500318866840512.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghuay@nvidia.com \
--cc=gordon.jin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.sun@intel.com \
--cc=yi.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®