From: "Rob Herring (Arm)" <robh@kernel.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: linux-kernel@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Junhui Liu <junhui.liu@pigmoral.tech>,
Conor Dooley <conor.dooley@microchip.com>,
netdev@vger.kernel.org, Philipp Zabel <p.zabel@pengutronix.de>,
Jakub Kicinski <kuba@kernel.org>,
linux-riscv@lists.infradead.org, Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, Vivian Wang <uwu@dram.page>,
Yixun Lan <dlan@gentoo.org>,
spacemit@lists.linux.dev,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: Add support for SpacemiT K1
Date: Thu, 03 Jul 2025 05:49:45 -0500 [thread overview]
Message-ID: <175153978342.612698.13197728053938266111.robh@kernel.org> (raw)
In-Reply-To: <20250703-net-k1-emac-v4-1-686d09c4cfa8@iscas.ac.cn>
On Thu, 03 Jul 2025 17:42:02 +0800, Vivian Wang wrote:
> The Ethernet MACs on SpacemiT K1 appears to be a custom design. SpacemiT
> refers to them as "EMAC", so let's just call them "spacemit,k1-emac".
>
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/net/spacemit,k1-emac.yaml | 81 ++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dts:36.36-37 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250703-net-k1-emac-v4-1-686d09c4cfa8@iscas.ac.cn
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-03 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 9:42 [PATCH net-next v4 0/2] Add Ethernet MAC " Vivian Wang
2025-07-03 9:42 ` [PATCH net-next v4 1/2] dt-bindings: net: Add " Vivian Wang
2025-07-03 10:49 ` Rob Herring (Arm) [this message]
2025-07-03 12:31 ` Vivian Wang
2025-07-08 2:19 ` Vivian Wang
2025-07-03 9:42 ` [PATCH net-next v4 2/2] net: spacemit: Add K1 Ethernet MAC Vivian Wang
2025-07-07 10:01 ` Simon Horman
2025-07-10 4:42 ` Vivian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175153978342.612698.13197728053938266111.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=junhui.liu@pigmoral.tech \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=spacemit@lists.linux.dev \
--cc=uwu@dram.page \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®