From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hugo Villeneuve <hugo@hugovil.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: fix efficiency regression when using gpio_chip_get_multiple()
Date: Fri, 4 Jul 2025 10:25:41 +0200 [thread overview]
Message-ID: <175161750676.14835.4100205816792446809.b4-ty@linaro.org> (raw)
In-Reply-To: <20250703191829.2952986-1-hugo@hugovil.com>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Thu, 03 Jul 2025 15:18:29 -0400, Hugo Villeneuve wrote:
> commit 74abd086d2ee ("gpiolib: sanitize the return value of
> gpio_chip::get_multiple()") altered the value returned by
> gc->get_multiple() in case it is positive (> 0), but failed to
> return for other cases (<= 0).
>
> This may result in the "if (gc->get)" block being executed and thus
> negates the performance gain that is normally obtained by using
> gc->get_multiple().
>
> [...]
Applied, thanks!
[1/1] gpiolib: fix efficiency regression when using gpio_chip_get_multiple()
https://git.kernel.org/brgl/linux/c/30e0fd3c0273dc106320081793793a424f1f1950
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
next prev parent reply other threads:[~2025-07-04 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 19:18 Hugo Villeneuve
2025-07-04 8:25 ` Bartosz Golaszewski [this message]
2025-07-04 8:26 ` Bartosz Golaszewski
2025-07-04 14:03 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175161750676.14835.4100205816792446809.b4-ty@linaro.org \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®