From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D6CC7618E for ; Fri, 21 Apr 2023 21:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233581AbjDUVSX convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2023 17:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbjDUVSV (ORCPT ); Fri, 21 Apr 2023 17:18:21 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F251B1FF0 for ; Fri, 21 Apr 2023 14:18:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 7B69B63CC16F; Fri, 21 Apr 2023 23:18:16 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SnRLdqdW0iV1; Fri, 21 Apr 2023 23:18:16 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 17D266418F2B; Fri, 21 Apr 2023 23:18:16 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id auZ6_yP3xkVD; Fri, 21 Apr 2023 23:18:16 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id EC79563CC16F; Fri, 21 Apr 2023 23:18:15 +0200 (CEST) Date: Fri, 21 Apr 2023 23:18:15 +0200 (CEST) From: Richard Weinberger To: ZhaoLong Wang Cc: Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , chengzhihao1 , yi zhang Message-ID: <1751647898.236371.1682111895850.JavaMail.zimbra@nod.at> In-Reply-To: <20230318015621.1408243-1-wangzhaolong1@huawei.com> References: <20230318015621.1408243-1-wangzhaolong1@huawei.com> Subject: Re: [PATCH 0/5] ubi: Enhanced fault injection capability for the UBI driver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: Enhanced fault injection capability for the UBI driver Thread-Index: zOuMq5RgU5mOajBYreOdiSG1qqplFg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "ZhaoLong Wang" > The existing fault injection capability of UBI is too simple. > It uses hard-coded fault probability values and lacks other > configurable options. As a result, these interfaces are difficult > to use when digging defects in the abnormal path of code and > reproducing some problems. > > The kernel provides a powerful fault injection framework, which > provides rich configurable fault injection attributes during runtime. > So it can be used to improve the fault injection capability of the > UBI driver. > > This series of patches refactor the existing fault injection interface > and add some fault injection types to help testers and developers > find potential problems in the code. In general I like having some new and advanced way to test UBI. But your patches seem to remove the old interface from debugfs, this will cause breakage of existing test scripts. So please keep the old interface too. Thanks, //richard