mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: hpa@zytor.com
To: Daniel Drake <drake@endlessm.com>, Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jian-Hong Pan <jian-hong@endlessm.com>,
	matt@codeblueprint.co.uk,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	linux-efi@vger.kernel.org, Len Brown <len.brown@intel.com>,
	linux-tip-commits@vger.kernel.org,
	Endless Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)
Date: Wed, 17 Apr 2019 08:15:55 -0700	[thread overview]
Message-ID: <17516564-37AC-4F77-9C0D-0DD71F8045EA@zytor.com> (raw)
In-Reply-To: <CAD8Lp45BLaoXF=RNcncqcTtNvaGHP72+a1CxcjoeBXDiw9TKbA@mail.gmail.com>

On April 17, 2019 5:38:41 AM PDT, Daniel Drake <drake@endlessm.com> wrote:
>On Wed, Apr 17, 2019 at 2:16 PM Ingo Molnar <mingo@kernel.org> wrote:
>> Ok, so acpi_gbl_reduced_hardware is set when the ... 'reduced
>hardware'
>> bit is set:
>>
>>         acpi_gbl_reduced_hardware = FALSE;
>>         if (acpi_gbl_FADT.flags & ACPI_FADT_HW_REDUCED) {
>>                 acpi_gbl_reduced_hardware = TRUE;
>>         }
>>
>>
>> which is described as:
>>
>>  #define ACPI_FADT_HW_REDUCED        (1<<20)     /* 20: [V5] ACPI
>hardware is not implemented (ACPI 5.0) */
>>
>> That seems counter-intuitive to me: if no full ACPI hardware is
>> implemented then we should assume reduced ACPI functionality, i.e. if
>the
>> EFI runtime is otherwise available we should default to it.
>
>It's a bit confusing, but my loose understanding is that previous
>versions of the ACPI spec required system implementors to implement
>the whole thing; but that's increasingly impractical today, e.g. with
>ARM systems coming along, which do not gel well with some of the
>historical x86-rooted design aspects that spilled over into ACPI. The
>V5 spec introduces reduced mode as an opt-in new feature, but for
>compatibility with pre-V5 implementations it needs to consider "full
>hardware" mode as the default.
>
>> Feel free to send a patch that makes EFI reboot the default one under
>> these circumstances,
>
>Just to check, you mean: EFI reboot (and shutdown) become the default
>methods when the machine is booted in EFI mode, and EFI stuff has not
>been disabled with a kernel parameter?
>Even when running in full hardware ACPI mode.
>
>Thanks
>Daniel

This, I believe, is known to not work.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

  reply	other threads:[~2019-04-17 15:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  8:01 [PATCH v2] x86/reboot: Use efi reboot for Acer TravelMate X514-51T Jian-Hong Pan
2019-04-16  7:52 ` [tip:x86/urgent] x86/reboot: Use EFI " tip-bot for Jian-Hong Pan
2019-04-16  8:07 ` [tip:x86/urgent] x86/reboot, efi: " tip-bot for Jian-Hong Pan
2019-04-16  8:20   ` EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T) Ingo Molnar
2019-04-16 11:35     ` Daniel Drake
2019-04-17  6:16       ` Ingo Molnar
2019-04-17 12:38         ` Daniel Drake
2019-04-17 15:15           ` hpa [this message]
2019-04-17 15:45             ` Ard Biesheuvel
2019-04-17 17:22               ` Prakhya, Sai Praneeth
2019-04-17 18:23                 ` Ingo Molnar
2019-04-17 19:07                   ` Ard Biesheuvel
2019-04-17 19:17                     ` Ingo Molnar
2019-04-17 16:37             ` Ingo Molnar
2019-04-17 16:51               ` hpa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17516564-37AC-4F77-9C0D-0DD71F8045EA@zytor.com \
    --to=hpa@zytor.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bp@alien8.de \
    --cc=drake@endlessm.com \
    --cc=jian-hong@endlessm.com \
    --cc=len.brown@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®