From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@infradead.org>,
Hannes Reinecke <hare@suse.de>,
mcgrof@kernel.org, Pankaj Raghav <p.raghav@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] block: reject bs > ps block devices when THP is disabled
Date: Mon, 07 Jul 2025 11:59:05 -0600 [thread overview]
Message-ID: <175191114597.897893.10689486110694082166.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250704092134.289491-1-p.raghav@samsung.com>
On Fri, 04 Jul 2025 11:21:34 +0200, Pankaj Raghav wrote:
> If THP is disabled and when a block device with logical block size >
> page size is present, the following null ptr deref panic happens during
> boot:
>
> [ [13.2 mK AOSAN: null-ptr-deref in range [0x0000000000000000-0x0000000000K0 0 0[07]
> [ 13.017749] RIP: 0010:create_empty_buffers+0x3b/0x380
> <snip>
> [ 13.025448] Call Trace:
> [ 13.025692] <TASK>
> [ 13.025895] block_read_full_folio+0x610/0x780
> [ 13.026379] ? __pfx_blkdev_get_block+0x10/0x10
> [ 13.027008] ? __folio_batch_add_and_move+0x1fa/0x2b0
> [ 13.027548] ? __pfx_blkdev_read_folio+0x10/0x10
> [ 13.028080] filemap_read_folio+0x9b/0x200
> [ 13.028526] ? __pfx_filemap_read_folio+0x10/0x10
> [ 13.029030] ? __filemap_get_folio+0x43/0x620
> [ 13.029497] do_read_cache_folio+0x155/0x3b0
> [ 13.029962] ? __pfx_blkdev_read_folio+0x10/0x10
> [ 13.030381] read_part_sector+0xb7/0x2a0
> [ 13.030805] read_lba+0x174/0x2c0
> <snip>
> [ 13.045348] nvme_scan_ns+0x684/0x850 [nvme_core]
> [ 13.045858] ? __pfx_nvme_scan_ns+0x10/0x10 [nvme_core]
> [ 13.046414] ? _raw_spin_unlock+0x15/0x40
> [ 13.046843] ? __switch_to+0x523/0x10a0
> [ 13.047253] ? kvm_clock_get_cycles+0x14/0x30
> [ 13.047742] ? __pfx_nvme_scan_ns_async+0x10/0x10 [nvme_core]
> [ 13.048353] async_run_entry_fn+0x96/0x4f0
> [ 13.048787] process_one_work+0x667/0x10a0
> [ 13.049219] worker_thread+0x63c/0xf60
>
> [...]
Applied, thanks!
[1/1] block: reject bs > ps block devices when THP is disabled
commit: 4cdf1bdd45ac78a088773722f009883af30ad318
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-07-07 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 9:21 Pankaj Raghav
2025-07-04 12:46 ` Matthew Wilcox
2025-07-04 14:05 ` Pankaj Raghav
2025-07-05 1:33 ` Luis Chamberlain
2025-07-07 17:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175191114597.897893.10689486110694082166.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®