From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Arnd Bergmann <arnd@arndb.de>, Quinn Tran <qutran@marvell.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] scsi: qla2xxx: avoid stack frame size warning in qla_dfs
Date: Mon, 14 Jul 2025 21:53:48 -0400 [thread overview]
Message-ID: <175193808975.2586181.3549891126119956725.b4-ty@oracle.com> (raw)
In-Reply-To: <20250620173232.864179-1-arnd@kernel.org>
On Fri, 20 Jun 2025 19:32:22 +0200, Arnd Bergmann wrote:
> The qla2x00_dfs_tgt_port_database_show() function constructs a fake
> fc_port_t object on the stack, which depending on the configuration
> is large enough to exceed the stack size warning limit:
>
> drivers/scsi/qla2xxx/qla_dfs.c:176:1: error: stack frame size (1392) exceeds limit (1280) in 'qla2x00_dfs_tgt_port_database_show' [-Werror,-Wframe-larger-than]
>
> Rework this function to no longer need the structure but instead
> call a custom helper function that just prints the data directly
> from the port_database_24xx structure.
>
> [...]
Applied to 6.17/scsi-queue, thanks!
[1/1] scsi: qla2xxx: avoid stack frame size warning in qla_dfs
https://git.kernel.org/mkp/scsi/c/6243146bb019
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2025-07-15 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 17:32 Arnd Bergmann
2025-06-25 1:13 ` Martin K. Petersen
2025-07-15 1:53 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175193808975.2586181.3549891126119956725.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=himanshu.madhani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@treblig.org \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®