From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 2/3] docs: dt: writing-bindings: Express better expectations of "specific"
Date: Tue, 8 Jul 2025 07:22:14 -0500 [thread overview]
Message-ID: <175197733309.276747.1347706075364482943.robh@kernel.org> (raw)
In-Reply-To: <20250707095019.66792-5-krzysztof.kozlowski@linaro.org>
On Mon, 07 Jul 2025 11:50:21 +0200, Krzysztof Kozlowski wrote:
> Devicetree bindings are supposed to be specific in terms of compatibles
> and other properties. Short "specific" has many implications, so extend
> the description to cover them:
>
> 1. Mention no family names and avoid generic SoC fallbacks in
> compatible. The list grew, mixing DO's and DON'T's, so split it into
> multiple items.
>
> 2. No properties implied by the compatible.
>
> 3. Document desired lack of ABI impact and acceptable solution if such
> needs arises: clearly marking it in commit msg.
>
> All above follows established Devicetree bindings maintainers review
> practice, so no new rules in practice are introduced here.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes in v2:
> Implement entire Conor's feedback:
> 1. Grammar
> 2. Split DO/DON'T in compatible section
> 3. Rephrase the ABI break
> ---
> .../devicetree/bindings/writing-bindings.rst | 27 +++++++++++++++----
> 1 file changed, 22 insertions(+), 5 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2025-07-08 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 9:50 [PATCH v2 1/3] docs: dt: writing-bindings: Rephrase typical fallback (superset) usage Krzysztof Kozlowski
2025-07-07 9:50 ` [PATCH v2 2/3] docs: dt: writing-bindings: Express better expectations of "specific" Krzysztof Kozlowski
2025-07-07 15:00 ` Conor Dooley
2025-07-08 12:22 ` Rob Herring (Arm) [this message]
2025-07-07 9:50 ` [PATCH v2 3/3] docs: dt: writing-bindings: Consistently use single-whitespace Krzysztof Kozlowski
2025-07-07 15:01 ` Conor Dooley
2025-07-08 12:22 ` Rob Herring (Arm)
2025-07-07 15:00 ` [PATCH v2 1/3] docs: dt: writing-bindings: Rephrase typical fallback (superset) usage Conor Dooley
2025-07-08 12:20 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175197733309.276747.1347706075364482943.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®