From: "Rob Herring (Arm)" <robh@kernel.org>
To: Pengyu Luo <mitltlatltl@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Charles Wang" <charles.goodix@gmail.com>,
devicetree@vger.kernel.org, "Hans de Goede" <hansg@kernel.org>,
"Luke Jones" <luke@ljones.dev>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Eric Biggers" <ebiggers@kernel.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Len Brown" <len.brown@intel.com>,
"Al Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document stylus support
Date: Thu, 10 Jul 2025 08:35:28 -0500 [thread overview]
Message-ID: <175215452823.2039713.12986563371135237841.robh@kernel.org> (raw)
In-Reply-To: <20250710115733.226670-2-mitltlatltl@gmail.com>
On Thu, 10 Jul 2025 19:57:32 +0800, Pengyu Luo wrote:
> Document stylus support. Optional support for DT properties:
> - `goodix,stylus-enable`
> - `goodix,stylus-pressure-level`
> - `touchscreen-x-mm`
> - `touchscreen-y-mm`
>
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
> ---
> .../bindings/input/touchscreen/goodix,gt9916.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml: properties:goodix,stylus-enable: 'description' is a dependency of 'type'
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250710115733.226670-2-mitltlatltl@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-10 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 11:57 [PATCH v2 0/2] input: touchscreen: goodix_berlin: Add " Pengyu Luo
2025-07-10 11:57 ` [PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document " Pengyu Luo
2025-07-10 13:35 ` Rob Herring (Arm) [this message]
2025-07-10 11:57 ` [PATCH v2 2/2] input: touchscreen: goodix_berlin: Add " Pengyu Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175215452823.2039713.12986563371135237841.robh@kernel.org \
--to=robh@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiggers@kernel.org \
--cc=gustavoars@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=krzk+dt@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mingo@kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®