From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Markus Stockhausen <markus.stockhausen@gmx.de>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH v2 2/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support
Date: Sat, 12 Jul 2025 16:22:29 -0500 [thread overview]
Message-ID: <175235534986.1684385.2174297303057488223.robh@kernel.org> (raw)
In-Reply-To: <20250712194255.7022-3-jelonek.jonas@gmail.com>
On Sat, 12 Jul 2025 19:42:54 +0000, Jonas Jelonek wrote:
> Add dt-bindings for RTL9310 series I2C controller.
>
> Adjust the regex for child-node address to account for the fact that
> RTL9310 supports 12 instead of only 8 SDA lines.
>
> Add a vendor-specific property to explicitly specify the
> Realtek-internal ID of the defined I2C controller/master. This is
> required, in particular for RTL9310, to describe the correct I2C
> master.
>
> Add compatibles for known SoC variants RTL9311, RTL9312 and RTL9313.
>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> ---
> .../bindings/i2c/realtek,rtl9301-i2c.yaml | 37 +++++++++++++++++--
> 1 file changed, 33 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.example.dtb: i2c@100c (realtek,rtl9310-i2c): realtek,mst-id: [0, 0, 0, 1] is not of type 'integer'
from schema $id: http://devicetree.org/schemas/i2c/realtek,rtl9301-i2c.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.example.dtb: i2c@100c (realtek,rtl9310-i2c): realtek,mst-id: size is 32, expected 8
from schema $id: http://devicetree.org/schemas/i2c/realtek,rtl9301-i2c.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250712194255.7022-3-jelonek.jonas@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-12 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 19:42 [PATCH v2 0/3] i2c: rework and extend RTL9300 I2C driver Jonas Jelonek
2025-07-12 19:42 ` [PATCH v2 1/3] i2c: rework RTL9300 I2C controller driver Jonas Jelonek
2025-07-12 19:42 ` [PATCH v2 2/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support Jonas Jelonek
2025-07-12 21:22 ` Rob Herring (Arm) [this message]
2025-07-14 6:00 ` Krzysztof Kozlowski
2025-07-20 19:51 ` Jonas Jelonek
2025-07-21 7:02 ` Krzysztof Kozlowski
2025-07-22 18:25 ` Jonas Jelonek
2025-07-23 6:22 ` Krzysztof Kozlowski
2025-07-23 7:49 ` Jonas Jelonek
2025-07-12 19:42 ` [PATCH v2 3/3] i2c: add RTL9310 support to RTL9300 I2C controller driver Jonas Jelonek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175235534986.1684385.2174297303057488223.robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jelonek.jonas@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.stockhausen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®