From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E26C77B73 for ; Thu, 27 Apr 2023 15:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244114AbjD0PP1 (ORCPT ); Thu, 27 Apr 2023 11:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243211AbjD0PPZ (ORCPT ); Thu, 27 Apr 2023 11:15:25 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23E1535A5; Thu, 27 Apr 2023 08:15:24 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id EDD7B66032B5; Thu, 27 Apr 2023 16:15:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682608522; bh=wx4QwWQd9NsnskAEPQUncauUhMSHJCUjAMBurj5VCPw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Jm/XTqkVdeGNCtWpZpEhTDlndoLNfCkYlhVE0tRHH+AnSHsVTPcFlQUYWKu5Q7O2Y hpQn5J88h7AS7Aj6hrxV1wJH0yVIBH81FJKTkx/4JEgSD9br9/nP2VIs/Jouzq4+GZ +XhVlV4yCgAdpn+yWv6IoqMBabKshxpvQcen9A/Lv0BicMihifmbxjDiUQqL7CQqPx q5gu7ZjrTVBE+6HLa/d7p4V+n6cQnigJR3HzoyjvPAMCjihPRFukIkbQzciS8/3Rnv OttUxoMFyh7orzPjG2FgdrOVgjsqJHBE88TBNtK25tiRtZZyaTAdt/Dvn8gdxmP4vu 92WRXZjLmQjBg== Message-ID: <17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com> Date: Thu, 27 Apr 2023 17:15:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195 From: AngeloGioacchino Del Regno To: "Jason-JH.Lin" , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: CK Hu , Rex-BC Chen , Singo Chang , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto: > Il 12/09/22 03:29, Jason-JH.Lin ha scritto: >> Since the gamma_set_common() function for previous SoC, >> such as  mt8173 and mt8183, is designed for 9bit-to-10bit >> conversion. >> mt8195 is using 10bit-to-12bit conversion, which is >> not compatible with the previous function. >> >> Thus, need to update the function to fit the need of mt8195. > > Hello, > can you please respin and fix this series on the latest linux-next? > > Besides, please test it carefully: as far as I can see, GNOME Night Light > (or others) are not working on MT8195 (color temperature/ccorr). > As for gamma itself, that's not working either; you can test it with a tool > that will create a color profile by applying a new VCGT table, please look > at [1] if you need tools. > > We can confirm that color correction works on at least MT8192 (colord), so > it's MT8195 at fault. > > [1]: https://github.com/zb3/gnome-gamma-tool > Nevermind. I've actually fixed this code and refactored it a bit as well. I'll push my own version soon. No action required. Regards, Angelo