From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64/gcs: Don't call gcs_free() when releasing task_struct
Date: Thu, 17 Jul 2025 11:46:17 +0100 [thread overview]
Message-ID: <175258790439.3684657.2697022341807842240.b4-ty@kernel.org> (raw)
In-Reply-To: <20250714-arm64-gcs-release-task-v2-1-8a83cadfc846@kernel.org>
On Mon, 14 Jul 2025 12:21:27 +0100, Mark Brown wrote:
> Currently we call gcs_free() when releasing task_struct but this is
> redundant, it attempts to deallocate any kernel managed userspace GCS
> which should no longer be relevant and resets values in the struct we're
> in the process of freeing.
>
> By the time arch_release_task_struct() is called the mm will have been
> disassociated from the task so the check for a mm in gcs_free() will
> always be false, for threads that are exiting leaving the mm active
> deactivate_mm() will have been called previously and freed any kernel
> managed GCS.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64/gcs: Don't call gcs_free() when releasing task_struct
https://git.kernel.org/arm64/c/75fdf823f94b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2025-07-17 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 11:21 Mark Brown
2025-07-17 10:46 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175258790439.3684657.2697022341807842240.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®