From: Vinod Koul <vkoul@kernel.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: nbpfaxi: Fix memory corruption in probe()
Date: Tue, 15 Jul 2025 20:52:04 +0530 [thread overview]
Message-ID: <175259292421.543905.3175578919645729434.b4-ty@kernel.org> (raw)
In-Reply-To: <b13c5225-7eff-448c-badc-a2c98e9bcaca@sabinyo.mountain>
On Tue, 01 Jul 2025 17:31:40 -0500, Dan Carpenter wrote:
> The nbpf->chan[] array is allocated earlier in the nbpf_probe() function
> and it has "num_channels" elements. These three loops iterate one
> element farther than they should and corrupt memory.
>
> The changes to the second loop are more involved. In this case, we're
> copying data from the irqbuf[] array into the nbpf->chan[] array. If
> the data in irqbuf[i] is the error IRQ then we skip it, so the iterators
> are not in sync. I added a check to ensure that we don't go beyond the
> end of the irqbuf[] array. I'm pretty sure this can't happen, but it
> seemed harmless to add a check.
>
> [...]
Applied, thanks!
[1/1] dmaengine: nbpfaxi: Fix memory corruption in probe()
commit: 188c6ba1dd925849c5d94885c8bbdeb0b3dcf510
Best regards,
--
~Vinod
prev parent reply other threads:[~2025-07-15 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 22:31 Dan Carpenter
2025-07-15 15:22 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175259292421.543905.3175578919645729434.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®