mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for John Stultz" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: John Stultz <jstultz@google.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched: Move update_curr_task logic into update_curr_se
Date: Wed, 16 Jul 2025 10:19:11 -0000	[thread overview]
Message-ID: <175266115160.406.16373206315111370971.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250712033407.2383110-5-jstultz@google.com>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     865d8cfb1672089e4b628d6899ac5c6e49787150
Gitweb:        https://git.kernel.org/tip/865d8cfb1672089e4b628d6899ac5c6e49787150
Author:        John Stultz <jstultz@google.com>
AuthorDate:    Sat, 12 Jul 2025 03:33:45 
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 14 Jul 2025 17:16:32 +02:00

sched: Move update_curr_task logic into update_curr_se

Absorb update_curr_task() into update_curr_se(), and
in the process simplify update_curr_common().

This will make the next step a bit easier.

Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://lkml.kernel.org/r/20250712033407.2383110-5-jstultz@google.com
---
 kernel/sched/fair.c | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b9b4bbb..8334580 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1164,6 +1164,14 @@ static s64 update_curr_se(struct rq *rq, struct sched_entity *curr)
 	curr->exec_start = now;
 	curr->sum_exec_runtime += delta_exec;
 
+	if (entity_is_task(curr)) {
+		struct task_struct *p = task_of(curr);
+
+		trace_sched_stat_runtime(p, delta_exec);
+		account_group_exec_runtime(p, delta_exec);
+		cgroup_account_cputime(p, delta_exec);
+	}
+
 	if (schedstat_enabled()) {
 		struct sched_statistics *stats;
 
@@ -1175,26 +1183,14 @@ static s64 update_curr_se(struct rq *rq, struct sched_entity *curr)
 	return delta_exec;
 }
 
-static inline void update_curr_task(struct task_struct *p, s64 delta_exec)
-{
-	trace_sched_stat_runtime(p, delta_exec);
-	account_group_exec_runtime(p, delta_exec);
-	cgroup_account_cputime(p, delta_exec);
-}
-
 /*
  * Used by other classes to account runtime.
  */
 s64 update_curr_common(struct rq *rq)
 {
 	struct task_struct *donor = rq->donor;
-	s64 delta_exec;
 
-	delta_exec = update_curr_se(rq, &donor->se);
-	if (likely(delta_exec > 0))
-		update_curr_task(donor, delta_exec);
-
-	return delta_exec;
+	return update_curr_se(rq, &donor->se);
 }
 
 /*
@@ -1219,10 +1215,6 @@ static void update_curr(struct cfs_rq *cfs_rq)
 	update_min_vruntime(cfs_rq);
 
 	if (entity_is_task(curr)) {
-		struct task_struct *p = task_of(curr);
-
-		update_curr_task(p, delta_exec);
-
 		/*
 		 * If the fair_server is active, we need to account for the
 		 * fair_server time whether or not the task is running on

  reply	other threads:[~2025-07-16 10:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-12  3:33 [PATCH v19 0/8] Single RunQueue Proxy Execution (v19) John Stultz
2025-07-12  3:33 ` [PATCH v19 1/8] sched: Add CONFIG_SCHED_PROXY_EXEC & boot argument to enable/disable John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for John Stultz
2025-07-28 13:21     ` Phil Auld
2025-07-12  3:33 ` [PATCH v19 2/8] locking/mutex: Rework task_struct::blocked_on John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2025-07-12  3:33 ` [PATCH v19 3/8] locking/mutex: Add p->blocked_on wrappers for correctness checks John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2025-07-12  3:33 ` [PATCH v19 4/8] sched: Move update_curr_task logic into update_curr_se John Stultz
2025-07-16 10:19   ` tip-bot2 for John Stultz [this message]
2025-07-12  3:33 ` [PATCH v19 5/8] sched: Fix runtime accounting w/ split exec & sched contexts John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for John Stultz
2025-07-12  3:33 ` [PATCH v19 6/8] sched: Add an initial sketch of the find_proxy_task() function John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for John Stultz
2025-07-12  3:33 ` [PATCH v19 7/8] sched: Fix proxy/current (push,pull)ability John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2025-07-12  3:33 ` [PATCH v19 8/8] sched: Start blocked_on chain processing in find_proxy_task() John Stultz
2025-07-16 10:19   ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2025-07-14 11:52 ` [PATCH v19 0/8] Single RunQueue Proxy Execution (v19) Peter Zijlstra
2025-07-14 23:39   ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175266115160.406.16373206315111370971.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=jstultz@google.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®