From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH v2 0/4] firmware: qcom: scm: fix potential race condition with tzmem
Date: Wed, 16 Jul 2025 23:30:54 -0500 [thread overview]
Message-ID: <175272667120.130869.4406679660383581017.b4-ty@kernel.org> (raw)
In-Reply-To: <20250630-qcom-scm-race-v2-0-fa3851c98611@linaro.org>
On Mon, 30 Jun 2025 14:12:01 +0200, Bartosz Golaszewski wrote:
> There's a race condition between the SCM call API consumers and the TZMem
> initialization in the SCM firmware driver. The internal __scm pointer is
> assigned - marking SCM as ready for accepting calls - before the tzmem
> memory pool is fully initialized. While the race is unlikely to be hit
> thanks to the SCM driver being initialized early, it still must be
> addressed.
>
> [...]
Applied, thanks!
[1/4] firmware: qcom: scm: remove unused arguments from SHM bridge routines
commit: 23972da96e1eee7f10c8ef641d56202ab9af8ba7
[2/4] firmware: qcom: scm: take struct device as argument in SHM bridge enable
commit: dc3f4e75c54c19bad9a70419afae00ce6baf3ebf
[3/4] firmware: qcom: scm: initialize tzmem before marking SCM as available
commit: 87be3e7a2d0030cda6314d2ec96b37991f636ccd
[4/4] firmware: qcom: scm: request the waitqueue irq *after* initializing SCM
commit: 7ab36b51c6bee56e1a1939063dd10d602fe49d13
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2025-07-17 4:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 12:12 Bartosz Golaszewski
2025-06-30 12:12 ` [PATCH v2 1/4] firmware: qcom: scm: remove unused arguments from SHM bridge routines Bartosz Golaszewski
2025-06-30 12:12 ` [PATCH v2 2/4] firmware: qcom: scm: take struct device as argument in SHM bridge enable Bartosz Golaszewski
2025-06-30 12:43 ` Konrad Dybcio
2025-06-30 12:12 ` [PATCH v2 3/4] firmware: qcom: scm: initialize tzmem before marking SCM as available Bartosz Golaszewski
2025-06-30 12:12 ` [PATCH v2 4/4] firmware: qcom: scm: request the waitqueue irq *after* initializing SCM Bartosz Golaszewski
2025-07-11 7:52 ` [PATCH v2 0/4] firmware: qcom: scm: fix potential race condition with tzmem Bartosz Golaszewski
2025-07-17 4:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175272667120.130869.4406679660383581017.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®