From: Lee Jones <lee@kernel.org>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Marek Vasut <marek.vasut@mailbox.org>,
Lukasz Majewski <lukma@denx.de>,
Christian Marangi <ansuelsmth@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: (subset) [PATCH v2] Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"
Date: Fri, 18 Jul 2025 14:27:13 +0100 [thread overview]
Message-ID: <175284523331.219050.5074159339576881850.b4-ty@kernel.org> (raw)
In-Reply-To: <6dcc77ee1c9676891d6250d8994850f521426a0f.1752334655.git.daniel@makrotopia.org>
On Sat, 12 Jul 2025 16:39:21 +0100, Daniel Golle wrote:
> This reverts commit c629c972b310af41e9e072febb6dae9a299edde6.
>
> While .led_blink_set() would previously put an LED into an unconditional
> permanently blinking state, the offending commit now uses same operation
> to (also?) set the blink timing of the netdev trigger when offloading.
>
> This breaks many if not all of the existing PHY drivers which offer
> offloading LED operations, as those drivers would just put the LED into
> blinking state after .led_blink_set() has been called.
>
> [...]
Applied, thanks!
[1/1] Revert "leds: trigger: netdev: Configure LED blink interval for HW offload"
commit: 26f732791f2bcab18f59c61915bbe35225f30136
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-07-18 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 15:39 Daniel Golle
2025-07-12 16:30 ` Andrew Lunn
2025-07-18 13:27 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175284523331.219050.5074159339576881850.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lukma@denx.de \
--cc=marek.vasut@mailbox.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®