From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Sean Paul <sean@poorly.run>,
freedreno@lists.freedesktop.org,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
Yongxing Mou <quic_yongmou@quicinc.com>,
Danila Tikhonov <danila@jiaxyga.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
dri-devel@lists.freedesktop.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Abhinav Kumar <abhinav.kumar@oss.qualcomm.com>,
linux-kernel@vger.kernel.org,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-clk@vger.kernel.org,
Rob Clark <robin.clark@oss.qualcomm.com>,
Michael Turquette <mturquette@baylibre.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Mahadevan <quic_mahap@quicinc.com>,
Simona Vetter <simona@ffwll.ch>,
Konrad Dybcio <konradybcio@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 0/5] dt-bindings: msm/dp: Add support for 4 pixel streams
Date: Sat, 19 Jul 2025 19:06:49 -0500 [thread overview]
Message-ID: <175296991792.777248.14434286781609695390.robh@kernel.org> (raw)
In-Reply-To: <20250717-dp_mst_bindings-v3-0-72ce08285703@oss.qualcomm.com>
On Thu, 17 Jul 2025 16:28:42 -0700, Jessica Zhang wrote:
> On some MSM chipsets, the display port controller is capable of supporting
> up to 4 streams.
>
> To drive these additional streams, the pixel clocks for the corresponding
> stream needs to be enabled.
>
> Fixup the documentation of some of the bindings to clarify exactly which
> stream they correspond to, then add the new bindings and device tree
> changes.
>
> ---
> Changes in v3:
> - Fixed dtschema errors (Rob Herring)
> - Documented all pixel stream clocks (Dmitry)
> - Ordered compatibility list alphabetically (Dmitry)
> - Dropped assigned-clocks too (Dmitry)
> - Link to v2: https://lore.kernel.org/r/20250530-dp_mst_bindings-v2-0-f925464d32a8@oss.qualcomm.com
>
> Changes in v2:
> - Rebased on top of next-20250523
> - Dropped merged maintainer patch
> - Added a patch to make the corresponding dts change to add pixel 1
> stream
> - Squashed pixel 0 and pixel 1 stream binding patches (Krzysztof)
> - Drop assigned-clock-parents bindings for dp-controller (Krzysztof)
> - Updated dp-controller.yaml to include all chipsets that support stream
> 1 pixel clock (Krzysztof)
> - Added missing minItems and if statement (Krzysztof)
> - Link to v1: https://lore.kernel.org/r/20241202-dp_mst_bindings-v1-0-9a9a43b0624a@quicinc.com
>
> ---
> Abhinav Kumar (4):
> dt-bindings: Fixup x1e80100 to add DP MST support
> dt-bindings: clock: Add SC7280 DISPCC DP pixel 1 clock binding
> dt-bindings: display/msm: drop assigned-clock-parents for dp controller
> dt-bindings: display/msm: add stream pixel clock bindings for MST
>
> Jessica Zhang (1):
> arm64: dts: qcom: Add MST pixel streams for displayport
>
> .../bindings/display/msm/dp-controller.yaml | 53 +++++++++++-----
> .../bindings/display/msm/qcom,sa8775p-mdss.yaml | 14 +++--
> .../bindings/display/msm/qcom,sar2130p-mdss.yaml | 11 ++--
> .../bindings/display/msm/qcom,sc7180-mdss.yaml | 3 -
> .../bindings/display/msm/qcom,sc7280-mdss.yaml | 12 ++--
> .../bindings/display/msm/qcom,sm7150-mdss.yaml | 5 --
> .../bindings/display/msm/qcom,sm8750-mdss.yaml | 11 ++--
> .../bindings/display/msm/qcom,x1e80100-mdss.yaml | 21 +++----
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 34 +++++++---
> arch/arm64/boot/dts/qcom/sar2130p.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 20 ++++--
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 72 +++++++++++++++-------
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 10 ++-
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 30 ++++++---
> include/dt-bindings/clock/qcom,dispcc-sc7280.h | 2 +
> 21 files changed, 235 insertions(+), 133 deletions(-)
> ---
> base-commit: 7a88d609b069b7d2f4d10113b18fea02921bedb1
> change-id: 20241202-dp_mst_bindings-7536ffc9ae2f
>
> Best regards,
> --
> Jessica Zhang <jessica.zhang@oss.qualcomm.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: base-commit 7a88d609b069b7d2f4d10113b18fea02921bedb1 not known, ignoring
Base: attempting to guess base-commit...
Base: tags/v6.16-rc2-698-g6b93840116df (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250717-dp_mst_bindings-v3-0-72ce08285703@oss.qualcomm.com:
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'enable-gpios': [[71, 74, 0]], 'power-supply': [[258]], 'pinctrl-0': [[259]], 'pinctrl-names': ['default'], 'port': {'endpoint': {'remote-endpoint': [[260]], 'phandle': 257}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'power-supply': [[276]], 'phandle': 597, 'port': {'endpoint': {'remote-endpoint': [[277]], 'phandle': 275}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['samsung,atna45dc02', 'samsung,atna33xc20'], 'enable-gpios': [[275, 4, 0]], 'power-supply': [[276]], 'pinctrl-0': [[277]], 'pinctrl-names': ['default'], 'port': {'endpoint': {'remote-endpoint': [[278]], 'phandle': 274}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1p42100-crd.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['samsung,atna45af01', 'samsung,atna33xc20'], 'enable-gpios': [[268, 4, 0]], 'power-supply': [[269]], 'pinctrl-0': [[270]], 'pinctrl-names': ['default'], 'port': {'endpoint': {'remote-endpoint': [[271]], 'phandle': 267}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1p42100-crd.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'power-supply': [[272]], 'backlight': [[273]], 'port': {'endpoint': {'remote-endpoint': [[274]], 'phandle': 271}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-qcp.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'power-supply': [[268]], 'port': {'endpoint': {'remote-endpoint': [[269]], 'phandle': 267}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-qcp.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['samsung,atna56ac03', 'samsung,atna33xc20'], 'enable-gpios': [[261, 4, 0]], 'power-supply': [[262]], 'pinctrl-0': [[263]], 'pinctrl-names': ['default'], 'port': {'endpoint': {'remote-endpoint': [[264]], 'phandle': 260}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'power-supply': [[276]], 'backlight': [[277]], 'phandle': 603, 'port': {'endpoint': {'remote-endpoint': [[278]], 'phandle': 275}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'power-supply': [[272]], 'backlight': [[273]], 'port': {'endpoint': {'remote-endpoint': [[274]], 'phandle': 271}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus15.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'backlight': [[266]], 'power-supply': [[267]], 'port': {'endpoint': {'remote-endpoint': [[268]], 'phandle': 265}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus15.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-crd.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['samsung,atna45af01', 'samsung,atna33xc20'], 'enable-gpios': [[278, 4, 0]], 'power-supply': [[279]], 'pinctrl-0': [[280]], 'pinctrl-names': ['default'], 'port': {'endpoint': {'remote-endpoint': [[281]], 'phandle': 277}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-crd.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): aux-bus: False schema does not allow {'panel': {'compatible': ['edp-panel'], 'backlight': [[266]], 'power-supply': [[267]], 'port': {'endpoint': {'remote-endpoint': [[268]], 'phandle': 265}}}}
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dtb: displayport-controller@aea0000 (qcom,x1e80100-dp): '#sound-dai-cells' is a required property
from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
prev parent reply other threads:[~2025-07-20 0:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 23:28 Jessica Zhang
2025-07-17 23:28 ` [PATCH v3 1/5] dt-bindings: Fixup x1e80100 to add DP MST support Jessica Zhang
2025-07-18 6:16 ` Krzysztof Kozlowski
2025-07-18 16:38 ` Jessica Zhang
2025-07-18 9:13 ` Dmitry Baryshkov
2025-07-19 0:16 ` Jessica Zhang
2025-07-19 8:42 ` Dmitry Baryshkov
2025-07-17 23:28 ` [PATCH v3 2/5] dt-bindings: clock: Add SC7280 DISPCC DP pixel 1 clock binding Jessica Zhang
2025-07-17 23:28 ` [PATCH v3 3/5] dt-bindings: display/msm: drop assigned-clock-parents for dp controller Jessica Zhang
2025-07-18 7:32 ` Krzysztof Kozlowski
2025-07-17 23:28 ` [PATCH v3 4/5] dt-bindings: display/msm: add stream pixel clock bindings for MST Jessica Zhang
2025-07-18 7:26 ` Krzysztof Kozlowski
2025-07-18 9:14 ` Dmitry Baryshkov
2025-07-18 9:16 ` Dmitry Baryshkov
2025-07-24 11:55 ` Dmitry Baryshkov
2025-07-17 23:28 ` [PATCH v3 5/5] arm64: dts: qcom: Add MST pixel streams for displayport Jessica Zhang
2025-07-18 9:20 ` Dmitry Baryshkov
2025-07-18 16:35 ` Jessica Zhang
2025-07-18 9:23 ` Konrad Dybcio
2025-07-18 16:37 ` Jessica Zhang
2025-07-18 9:22 ` [PATCH v3 0/5] dt-bindings: msm/dp: Add support for 4 pixel streams Dmitry Baryshkov
2025-07-18 16:43 ` Jessica Zhang
2025-07-19 9:14 ` [PATCH] dt-bindings: display/msm: dp-controller: allow eDP for X1E8 and SA8775P Dmitry Baryshkov
2025-07-21 14:38 ` Rob Herring (Arm)
2025-07-28 18:29 ` Jessica Zhang
2025-07-28 18:59 ` Dmitry Baryshkov
2025-07-20 0:06 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175296991792.777248.14434286781609695390.robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=abhinav.kumar@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mahap@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=quic_yongmou@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®