From: "Rob Herring (Arm)" <robh@kernel.org>
To: Aaron Kling <webgeek1234@gmail.com>
Cc: Azkali Manad <a.ffcc7@gmail.com>, Zhang Rui <rui.zhang@intel.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, JC Kuo <jckuo@nvidia.com>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Stephen Boyd <sboyd@kernel.org>,
Nagarjuna Kristam <nkristam@nvidia.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
linux-phy@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Thierry Reding <treding@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Vinod Koul <vkoul@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/17] arm64: tegra: Add Tegra210B01 support
Date: Mon, 21 Jul 2025 09:22:40 -0500 [thread overview]
Message-ID: <175310755862.577282.10932067975211977362.robh@kernel.org> (raw)
In-Reply-To: <20250720-t210b01-v2-0-9cb209f1edfc@gmail.com>
On Sun, 20 Jul 2025 21:14:54 -0500, Aaron Kling wrote:
> Also known as Tegra X1+, the Tegra210B01 has higher CPU and GPU clocks
> than the original Tegra210.
>
> This series adds Tegra210B01 support to several drivers, as a slight
> extension to the existing Tegra210 support. Then adds a generic soc dtsi
> in the same vein as other tegra archs. And finally adds a barebones
> device dts to be used for dt checks. Further device support will be
> submitted in later series.
>
> Earlier internal revisions of this series included changes to the dfll
> driver to support Tegra210B01, but those did not work in testing, thus
> was dropped from the series. A bindings update to match is still in the
> series so the soc dtsi can declare a separate compatible from Tegra210,
> preventing the driver from attempting incorrect initialization on
> Tegra210B01.
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> Changes in v2:
> - Fix patch 1 subject
> - Add descriptive name in patch 8
> - Fix copy-paste error in patch 13, discovered by kernel ci
> - Link to v1: https://lore.kernel.org/r/20250714-t210b01-v1-0-e3f5f7de5dce@gmail.com
>
> ---
> Aaron Kling (16):
> dt-bindings: soc: tegra: pmc: Document Tegra210B01
> dt-bindings: phy: tegra-xusb: Document Tegra210B01
> dt-bindings: usb: tegra-xusb: Document Tegra210B01
> dt-bindings: usb: tegra-xudc: Document Tegra210B01
> dt-bindings: thermal: tegra: Document Tegra210B01
> dt-bindings: clock: tegra: Document Tegra210B01
> dt-bindings: clock: tegra124-dfll: Document Tegra210B01
> dt-bindings: tegra: Document Shield TV 2019
> phy: tegra: xusb: Add Tegra201B01 Support
> usb: xhci: tegra: Add Tegra210B01 support
> usb: gadget: tegra-xudc: Add Tegra210B01 Support
> thermal: tegra: Add Tegra210B01 Support
> clk: tegra: Add Tegra210B01 support
> arm64: tegra: Add BPMP node for Tegra210
> arm64: tegra: Add Tegra210B01 support
> arm64: tegra: Add support for NVIDIA Shield TV Pro 2019
>
> Azkali Manad (1):
> soc/tegra: pmc: Add Tegra210B01 support
>
> Documentation/devicetree/bindings/arm/tegra.yaml | 6 +
> .../bindings/clock/nvidia,tegra124-dfll.txt | 1 +
> .../bindings/clock/nvidia,tegra20-car.yaml | 1 +
> .../bindings/phy/nvidia,tegra210-xusb-padctl.yaml | 4 +-
> .../bindings/soc/tegra/nvidia,tegra20-pmc.yaml | 5 +-
> .../bindings/thermal/nvidia,tegra124-soctherm.yaml | 2 +
> .../devicetree/bindings/usb/nvidia,tegra-xudc.yaml | 2 +
> .../bindings/usb/nvidia,tegra210-xusb.yaml | 4 +-
> arch/arm64/boot/dts/nvidia/Makefile | 1 +
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 11 +
> .../boot/dts/nvidia/tegra210b01-p2894-0050-a08.dts | 10 +
> arch/arm64/boot/dts/nvidia/tegra210b01-p2894.dtsi | 70 +
> arch/arm64/boot/dts/nvidia/tegra210b01.dtsi | 64 +
> drivers/clk/tegra/Makefile | 1 +
> drivers/clk/tegra/clk-tegra-periph.c | 3 +
> drivers/clk/tegra/clk-tegra210b01.c | 3758 ++++++++++++++++++++
> drivers/clk/tegra/clk-utils.c | 5 +-
> drivers/clk/tegra/clk.c | 19 +-
> drivers/clk/tegra/clk.h | 6 +
> drivers/phy/tegra/xusb-tegra210.c | 41 +
> drivers/phy/tegra/xusb.c | 4 +
> drivers/phy/tegra/xusb.h | 1 +
> drivers/soc/tegra/pmc.c | 117 +
> drivers/thermal/tegra/soctherm.c | 4 +
> drivers/thermal/tegra/soctherm.h | 1 +
> drivers/thermal/tegra/tegra210-soctherm.c | 78 +
> drivers/usb/gadget/udc/tegra-xudc.c | 20 +
> drivers/usb/host/xhci-tegra.c | 25 +
> include/dt-bindings/clock/tegra210-car.h | 5 +-
> 29 files changed, 4262 insertions(+), 7 deletions(-)
> ---
> base-commit: 347e9f5043c89695b01e66b3ed111755afcf1911
> change-id: 20250509-t210b01-c154ca0f8994
>
> Best regards,
> --
> Aaron Kling <webgeek1234@gmail.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 347e9f5043c89695b01e66b3ed111755afcf1911
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250720-t210b01-v2-0-9cb209f1edfc@gmail.com:
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /pcie@1003000: failed to match any schema with compatible: ['nvidia,tegra210-pcie']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /host1x@50000000/tsec@54100000: failed to match any schema with compatible: ['nvidia,tegra210-tsec']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /host1x@50000000/tsec@54500000: failed to match any schema with compatible: ['nvidia,tegra210-tsec']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /gpu@57000000: failed to match any schema with compatible: ['nvidia,gm20b']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /interrupt-controller@60004000: failed to match any schema with compatible: ['nvidia,tegra210-ictlr']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /memory-controller@70019000: failed to match any schema with compatible: ['nvidia,tegra210-mc']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: external-memory-controller@7001b000 (nvidia,tegra210-emc): '#cooling-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/memory-controllers/nvidia,tegra210-emc.yaml#
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /clock@70110000: failed to match any schema with compatible: ['nvidia,tegra210b01-dfll']
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: usb-phy@7d000000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long
'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy']
'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml#
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /usb-phy@7d000000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: usb-phy@7d004000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long
'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy']
'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy']
from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml#
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /usb-phy@7d004000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy']
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: cpu@0 (arm,cortex-a57): 'operating-points' is a dependency of 'clock-latency'
from schema $id: http://devicetree.org/schemas/arm/cpus.yaml#
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: cpu@0 (arm,cortex-a57): Unevaluated properties are not allowed ('clock-latency' was unexpected)
from schema $id: http://devicetree.org/schemas/arm/cpus.yaml#
arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: thermal-zones: mem-thermal:cooling-maps: 'dram-active', 'dram-passive' do not match any of the regexes: '^map[-a-zA-Z0-9]*$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p2371-0000.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210-p2571.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210-smaug.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp']
next prev parent reply other threads:[~2025-07-21 14:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 2:14 Aaron Kling via B4 Relay
2025-07-21 2:14 ` [PATCH v2 01/17] dt-bindings: soc: tegra: pmc: Document Tegra210B01 Aaron Kling via B4 Relay
2025-07-21 9:07 ` Krzysztof Kozlowski
2025-07-21 2:14 ` [PATCH v2 02/17] dt-bindings: phy: tegra-xusb: " Aaron Kling via B4 Relay
2025-07-21 2:14 ` [PATCH v2 03/17] dt-bindings: usb: " Aaron Kling via B4 Relay
2025-07-21 2:14 ` [PATCH v2 04/17] dt-bindings: usb: tegra-xudc: " Aaron Kling via B4 Relay
2025-07-21 2:14 ` [PATCH v2 05/17] dt-bindings: thermal: tegra: " Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 06/17] dt-bindings: clock: " Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 07/17] dt-bindings: clock: tegra124-dfll: " Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 08/17] dt-bindings: tegra: Document Shield TV 2019 Aaron Kling via B4 Relay
2025-07-21 20:15 ` Rob Herring (Arm)
2025-07-21 2:15 ` [PATCH v2 09/17] soc/tegra: pmc: Add Tegra210B01 support Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 10/17] phy: tegra: xusb: Add Tegra201B01 Support Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 11/17] usb: xhci: tegra: Add Tegra210B01 support Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 12/17] usb: gadget: tegra-xudc: Add Tegra210B01 Support Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 13/17] thermal: tegra: " Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 14/17] clk: tegra: Add Tegra210B01 support Aaron Kling via B4 Relay
2025-09-21 15:44 ` Stephen Boyd
2026-07-23 20:48 ` Aaron Kling
2025-07-21 2:15 ` [PATCH v2 15/17] arm64: tegra: Add BPMP node for Tegra210 Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 16/17] arm64: tegra: Add Tegra210B01 support Aaron Kling via B4 Relay
2025-07-21 2:15 ` [PATCH v2 17/17] arm64: tegra: Add support for NVIDIA Shield TV Pro 2019 Aaron Kling via B4 Relay
2025-07-21 14:22 ` Rob Herring (Arm) [this message]
2025-07-31 21:45 ` [PATCH v2 00/17] arm64: tegra: Add Tegra210B01 support Aaron Kling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175310755862.577282.10932067975211977362.robh@kernel.org \
--to=robh@kernel.org \
--cc=a.ffcc7@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mturquette@baylibre.com \
--cc=nkristam@nvidia.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vkoul@kernel.org \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®