mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: dri-devel@lists.freedesktop.org,
	Conor Dooley <conor+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Maxime Ripard <mripard@kernel.org>,
	 Christophe Roullier <christophe.roullier@foss.st.com>,
	 Yannick Fertre <yannick.fertre@foss.st.com>,
	Will Deacon <will@kernel.org>,
	 devicetree@vger.kernel.org,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	 Philippe Cornu <philippe.cornu@foss.st.com>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 linux-arm-kernel@lists.infradead.org,
	Simona Vetter <simona@ffwll.ch>,
	 linux-kernel@vger.kernel.org, David Airlie <airlied@gmail.com>,
	 linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 01/12] dt-bindings: display: st: add new compatible to LTDC device
Date: Fri, 25 Jul 2025 07:12:23 -0500	[thread overview]
Message-ID: <175344554296.803203.4450272226884409035.robh@kernel.org> (raw)
In-Reply-To: <20250725-drm-misc-next-v1-1-a59848e62cf9@foss.st.com>


On Fri, 25 Jul 2025 12:03:53 +0200, Raphael Gallais-Pou wrote:
> The new STMicroelectronics SoC features a display controller similar to
> the one used in previous SoCs.  Because there is additional registers,
> it is incompatible with existing IPs.
> 
> Add the new name to the list of compatible string.
> 
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
>  .../devicetree/bindings/display/st,stm32-ltdc.yaml | 37 +++++++++++++++++++---
>  1 file changed, 33 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml:78:7: [warning] wrong indentation: expected 8 but found 6 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml: else:properties:clock-names: {'maxItems': 4, 'items': [{'const': 'bus'}, {'const': 'lcd'}, {'const': 'ref'}, {'const': 'lvds'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml: then:properties:clock-names: {'maxItems': 1, 'items': [{'const': 'lcd'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250725-drm-misc-next-v1-1-a59848e62cf9@foss.st.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-07-25 12:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 10:03 [PATCH 00/12] Enable display support for STM32MP25 Raphael Gallais-Pou
2025-07-25 10:03 ` [PATCH 01/12] dt-bindings: display: st: add new compatible to LTDC device Raphael Gallais-Pou
2025-07-25 12:12   ` Rob Herring (Arm) [this message]
2025-07-25 19:49   ` Rob Herring
2025-07-28 10:35     ` Raphael Gallais-Pou
2025-07-25 10:03 ` [PATCH 02/12] dt-bindings: display: st,stm32-ltdc: add access-controllers property Raphael Gallais-Pou
2025-07-25 12:12   ` Rob Herring (Arm)
2025-07-25 19:50   ` Rob Herring (Arm)
2025-07-25 10:03 ` [PATCH 03/12] dt-bindings: display: st,stm32mp25-lvds: " Raphael Gallais-Pou
2025-07-29 16:31   ` Rob Herring
2025-07-25 10:03 ` [PATCH 04/12] dt-bindings: display: st,stm32mp25-lvds: add power-domains property Raphael Gallais-Pou
2025-07-29 16:31   ` Rob Herring (Arm)
2025-07-25 10:03 ` [PATCH 05/12] dt-bindings: arm: stm32: add required #clock-cells property Raphael Gallais-Pou
2025-07-29 16:32   ` Rob Herring (Arm)
2025-07-25 10:03 ` [PATCH 06/12] drm/stm: ltdc: support new hardware version for STM32MP25 SoC Raphael Gallais-Pou
2025-07-25 10:03 ` [PATCH 07/12] drm/stm: ltdc: handle lvds pixel clock Raphael Gallais-Pou
2025-07-25 10:04 ` [PATCH 08/12] arm64: dts: st: add ltdc support on stm32mp251 Raphael Gallais-Pou
2025-07-25 10:04 ` [PATCH 09/12] arm64: dts: st: add lvds support on stm32mp255 Raphael Gallais-Pou
2025-07-25 11:08   ` [Linux-stm32] " Clement LE GOFFIC
2025-07-25 11:13     ` Clement LE GOFFIC
2025-07-25 14:52       ` Raphael Gallais-Pou
2025-07-25 10:04 ` [PATCH 10/12] arm64: dts: st: add clock-cells to syscfg node on stm32mp251 Raphael Gallais-Pou
2025-07-25 10:04 ` [PATCH 11/12] arm64: dts: st: enable display support on stm32mp257f-ev1 board Raphael Gallais-Pou
2025-07-25 10:04 ` [PATCH 12/12] arm64: dts: st: add loopback clocks on LTDC node Raphael Gallais-Pou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175344554296.803203.4450272226884409035.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mripard@kernel.org \
    --cc=philippe.cornu@foss.st.com \
    --cc=raphael.gallais-pou@foss.st.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=will@kernel.org \
    --cc=yannick.fertre@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®