From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Joel Selvaraj <joelselvaraj.oss@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Dang Huynh <danct12@riseup.net>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH v10 2/2] Input: Add Novatek NT36xxx touchscreen driver
Date: Wed, 16 Aug 2023 19:36:10 +0200 [thread overview]
Message-ID: <17542518-42ff-46f6-8304-fb8a214bfa77@linaro.org> (raw)
In-Reply-To: <2980f5e6-40b0-4ab2-ae73-bceeb97b4de5@gmail.com>
On 16.08.2023 03:09, Joel Selvaraj wrote:
> Hi Konrad Dybcio,
>
> On 8/8/23 18:38, Konrad Dybcio wrote:
>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> This is a driver for the Novatek in-cell touch controller and
>> supports various chips from the NT36xxx family, currently
>> including NT36525, NT36672A, NT36676F, NT36772 and NT36870.
>
> In kernel v6.4, a basic novatek touchscreen driver was introduced [1].
> I was able to tweak IT a bit (add devicetree compatible, regulator support, remove chip id hardcode) and get it properly working in my Xiaomi Poco F1 which has Novatek NT36672A touchscreen. Probably the other ICs will also work. So, do we really need a separate touchscreen driver? Maybe the existing one can be improved to add more features if needed?
Do you have your end outcome somewhere?
I can take a look and compare if anything's missing..
>
> Personally I have been looking forward to the v10 of this patchseries :) Thanks for working on this! But, yeah, we need to decide if we need this to be a separate driver.
We'll see, I was hoping I could add firmware loading, SPI transport and
eventually pen support..
Konrad
next prev parent reply other threads:[~2023-08-16 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 23:38 [PATCH v10 0/2] " Konrad Dybcio
2023-08-08 23:38 ` [PATCH v10 1/2] dt-bindings: touchscreen: Add binding for Novatek NT36xxx ICs Konrad Dybcio
2023-08-08 23:38 ` [PATCH v10 2/2] Input: Add Novatek NT36xxx touchscreen driver Konrad Dybcio
2023-08-16 1:09 ` Joel Selvaraj
2023-08-16 17:36 ` Konrad Dybcio [this message]
2023-08-17 22:17 ` Joel Selvaraj
2023-09-01 0:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17542518-42ff-46f6-8304-fb8a214bfa77@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=joelselvaraj.oss@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®