mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Lakshay Piplani <lakshay.piplani@nxp.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
	 priyanka.jain@nxp.com, krzk+dt@kernel.org,
	shashank.rebbapragada@nxp.com,  conor+dt@kernel.org,
	linux-rtc@vger.kernel.org, vikash.bansal@nxp.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rtc: pcf85363: add support for timestamp and watchdog
Date: Fri, 08 Aug 2025 08:29:02 -0500	[thread overview]
Message-ID: <175465973963.5932.7440128759454055701.robh@kernel.org> (raw)
In-Reply-To: <20250808112246.4169280-1-lakshay.piplani@nxp.com>


On Fri, 08 Aug 2025 16:52:45 +0530, Lakshay Piplani wrote:
> Extend the device tree binding for NXP PCF85263/PCF85363 RTC with:
> - Timestamp mode configuration
> - Watchdog timer configuration
> 
> Also introduce a new header 'pcf85363-tsr.h' to expose
> macros for timestamp mode fields, improving readability
> of device tree file.
> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@nxp.com>
> ---
>  .../devicetree/bindings/rtc/nxp,pcf85363.yaml | 44 ++++++++++++++++++-
>  include/dt-bindings/rtc/pcf85363-tsr.h        | 28 ++++++++++++
>  2 files changed, 71 insertions(+), 1 deletion(-)
>  create mode 100644 include/dt-bindings/rtc/pcf85363-tsr.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/nxp,pcf85363.yaml: nxp,timestamp-mode: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250808112246.4169280-1-lakshay.piplani@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-08-08 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 11:22 Lakshay Piplani
2025-08-08 11:22 ` [PATCH 2/2] rtc: pcf85363: add support for additional features Lakshay Piplani
2025-08-09  4:39   ` kernel test robot
2025-08-08 13:29 ` Rob Herring (Arm) [this message]
2025-08-08 19:23 ` [PATCH 1/2] rtc: pcf85363: add support for timestamp and watchdog Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175465973963.5932.7440128759454055701.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lakshay.piplani@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=priyanka.jain@nxp.com \
    --cc=shashank.rebbapragada@nxp.com \
    --cc=vikash.bansal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®