From: Jens Axboe <axboe@kernel.dk>
To: Zheng Qixing <zhengqixing@huaweicloud.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
houtao1@huawei.com, zhengqixing@huawei.com,
lilingfeng3@huawei.com, nilay@linux.ibm.com
Subject: Re: [PATCH v2] block: fix kobject double initialization in add_disk
Date: Mon, 11 Aug 2025 08:01:50 -0600 [thread overview]
Message-ID: <175492091078.697940.9736842876552825184.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250808053609.3237836-1-zhengqixing@huaweicloud.com>
On Fri, 08 Aug 2025 13:36:09 +0800, Zheng Qixing wrote:
> Device-mapper can call add_disk() multiple times for the same gendisk
> due to its two-phase creation process (dm create + dm load). This leads
> to kobject double initialization errors when the underlying iSCSI devices
> become temporarily unavailable and then reappear.
>
> However, if the first add_disk() call fails and is retried, the queue_kobj
> gets initialized twice, causing:
>
> [...]
Applied, thanks!
[1/1] block: fix kobject double initialization in add_disk
commit: 343dc5423bfe876c12bb80c56f5e44286e442a07
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-08-11 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 5:36 Zheng Qixing
2025-08-08 7:15 ` Nilay Shroff
2025-08-08 7:23 ` Yu Kuai
2025-08-08 7:51 ` Nilay Shroff
2025-08-08 7:34 ` Yu Kuai
2025-08-10 15:08 ` Christoph Hellwig
2025-08-11 1:04 ` Yu Kuai
2025-08-11 8:00 ` Ming Lei
2025-08-11 14:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175492091078.697940.9736842876552825184.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengqixing@huawei.com \
--cc=zhengqixing@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®