From: Paolo Abeni <pabeni@redhat.com>
To: Coia Prant <coiaprant@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Heiko Stuebner <heiko@sntech.de>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Fabio Baltieri <fabio.baltieri@gmail.com>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: pcs: xpcs: make supported_interfaces authoritative
Date: Tue, 10 Nov 2026 15:41:12 +0100 [thread overview]
Message-ID: <1754e4c8-3b6e-4983-a7fb-d3444c1156c1@redhat.com> (raw)
In-Reply-To: <20261102212506.3348537-4-coiaprant@gmail.com>
On 11/2/26 22:25, Coia Prant wrote:
> diff --git a/drivers/net/pcs/pcs-xpcs-rk.c b/drivers/net/pcs/pcs-xpcs-rk.c
> index 6f0a110e32d2..25fdc9c6b72c 100644
> --- a/drivers/net/pcs/pcs-xpcs-rk.c
> +++ b/drivers/net/pcs/pcs-xpcs-rk.c
> @@ -483,6 +483,7 @@ struct dw_xpcs *xpcs_rk_create(struct device *dev, struct device_node *pcs, int
> struct platform_device *pdev;
> struct dw_xpcs_rk *pxpcs;
> struct dw_xpcs *xpcs;
> + DECLARE_PHY_INTERFACE_MASK_ZERO(supported_interfaces);
Please respect the reverse christmas tree order above.
>
> if (!of_device_is_available(pcs))
> return ERR_PTR(-ENODEV);
> @@ -536,6 +537,15 @@ struct dw_xpcs *xpcs_rk_create(struct device *dev, struct device_node *pcs, int
> return xpcs;
> }
>
> + /*
> + * The RK3568 XPCS supports 1000BASE-X, SGMII and QSGMII.
> + */
> + __set_bit(PHY_INTERFACE_MODE_1000BASEX, supported_interfaces);
> + __set_bit(PHY_INTERFACE_MODE_SGMII, supported_interfaces);
> + __set_bit(PHY_INTERFACE_MODE_QSGMII, supported_interfaces);
Sashiko thinks this last statement is a no op:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261102212506.3348537-1-coiaprant@gmail.com
I don't think this is 'net' material, I suggest resubmitting for
net-next.
/P
next prev parent reply other threads:[~2026-11-10 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 21:25 [PATCH net v3 0/2] net: phy: fix PHY interface mask initialization and XPCS usage Coia Prant
2026-11-02 21:25 ` [PATCH net v3 1/2] net: phy: move DECLARE_PHY_INTERFACE_MASK_ZERO to core Coia Prant
2026-11-02 21:25 ` [PATCH net v3 2/2] net: pcs: xpcs: make supported_interfaces authoritative Coia Prant
2026-11-10 14:41 ` Paolo Abeni [this message]
2026-11-10 15:57 ` Coia Prant
2026-11-02 21:28 ` [PATCH net v3 0/2] net: phy: fix PHY interface mask initialization and XPCS usage netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1754e4c8-3b6e-4983-a7fb-d3444c1156c1@redhat.com \
--to=pabeni@redhat.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=coiaprant@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fabio.baltieri@gmail.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®